Re: [PATCH] bcachefs: fix incorrect usage of REQ_OP_FLUSH

[Christoph Hellwig <hch@lst.de>]

On Mon, Jan 22, 2024 at 12:42:24PM -0500, Kent Overstreet wrote:
> updating my tests for the MD_FAULTY removal, then will do. Is there
> anything you want me to look for?

Nothing fancy.  Just that you do data integrity operations and do
not see an error.

> considering most tests won't break or won't clearly break if flush/fua
> is being dropped (even generic/388 was passing reliably, of course,
> since virtual block devices aren't going to reorder writes...) maybe we
> could do some print statement sanity checking...

Well, xfstests is not very good about power fail testing, because it
can't inject a power fail..  Which is a problem in it's own, but
would need hardware power failing or at least some pretty good VM
emulation of the same outside the scope of the actual xfstests runner.

But basically what this patch needs is just seeing that you don't
get I/O errors on anything that flushes, which on currently mainline
without the patch you should be seeing.