From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f170.google.com (mail-yw1-f170.google.com [209.85.128.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F0EED14039D for ; Wed, 6 Mar 2024 19:59:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709755202; cv=none; b=ofXtkhjmSGS2iTiQ9xjdO4fgF5qd+4HTcHAfEvWAe6nOXFqaG2LCmVfe2mWhk2Snn68aTtJNuKaq2J+1z4FP4jv0JgKkV694zjQa+2AWVTqlWPC3oYXQr8tb1tsjj2jDtkeBCsKx0U51sz09v7OkWj1+nR7MlsrsNtdFrdqIJwY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709755202; c=relaxed/simple; bh=MJQooKERrkO5M8FdxXsbgrCB1vQwZZRXngnYowa1Ucg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=r2ccO93QkBJXTtXJmlIR1ZzgvEi44T0tMFtPikOUJfw3/pjaNnPsmWrkaV/uJzGU7JFpLnCtZOq3LMeItu1PdqtaB4HC7Gbp+exj7ELHRIyPwZCzvqi8u2oHEKCvB8Nl5SwB2+/2s9THEyxf15E9J9qSwSpBClnMVHEZIq5aBjk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=toxicpanda.com; spf=none smtp.mailfrom=toxicpanda.com; dkim=pass (2048-bit key) header.d=toxicpanda-com.20230601.gappssmtp.com header.i=@toxicpanda-com.20230601.gappssmtp.com header.b=nxITYk6F; arc=none smtp.client-ip=209.85.128.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=toxicpanda.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=toxicpanda.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=toxicpanda-com.20230601.gappssmtp.com header.i=@toxicpanda-com.20230601.gappssmtp.com header.b="nxITYk6F" Received: by mail-yw1-f170.google.com with SMTP id 00721157ae682-6096ab005c0so1377737b3.1 for ; Wed, 06 Mar 2024 11:59:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toxicpanda-com.20230601.gappssmtp.com; s=20230601; t=1709755198; x=1710359998; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=nk0/J29KPf4TmmeCSNMEsRp4h+k2/fvkEQwAaLlHWxs=; b=nxITYk6FUOJOhKf/sKhG47NLK2mwoGTzHmTNNhxNIk7Bj8T0g3ZXECO7EtcSbbER1L XjxBYhZohxdwY4VBAYKuMI4JSwJEYP2iAigz9VB0licnoowBnxfUxJ9tGsxhL5sZow5+ sOkvA06fPJzle4rR3N4lrtCRMvFVd1tv6txgRiDRczMNjT3LuReoqnwbMQf7Yqx95zzO mde9jwIbLHrz1zpSU52WxOFTXRGf9+TA0pTf5na5pOZvEySIAMVSz+RHkZHJFSTsoiwT WJyfZSZrEu56E7OmanKvlynbnnJAqGBgJtm3YxTqt8khigdtDEZGkQq6smn02PrGzagD k8zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709755198; x=1710359998; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=nk0/J29KPf4TmmeCSNMEsRp4h+k2/fvkEQwAaLlHWxs=; b=BHvrZY2Y0vKW+HQ4hDlwFId8H7txmoKY3BQa1leCWf6qEzkPUZbBTqrrxtSaBf4P53 cLIwM+LHR2Cw80JKcBN3TubbN4pRqML16AcpH9xm4OoSpo+uYBJ5qhtYyAaxLq2Vn10a OyDM8xEdvx9ww3YaLZsaj15z/dYiopoJMuYZ+85t9P6ESGa0+b4Ea0m/ioUHay6D8L2P 6c8H1/Vz64arsElRyhQh90E2BA/t1rvaVs0xYNYlhG4/hAO9BH7Q64lyRaTBIZs/TIth IMlPsQ9BHtTS/pZu1MBHapz6KXJFL1JKHJgLbw9MXn7fhqp9K08Z06IsEG6eUQUCa+q4 DVNQ== X-Forwarded-Encrypted: i=1; AJvYcCXhUfc16moqHC7PiWDFh9TxqtFeZRzIo8BWDAT1aUzevdneL3lxIxNE/uvVuQhaiL878eVFs9X2gIdjbL1dPjSsgDWqLoPt59D/+d3KkMs= X-Gm-Message-State: AOJu0Ywb6/wNx4o1OfLdO0Cw2nZ8Ee9C8WYQBH4SRPAhoo0pi0BO01xy ACrpeXql/tpXZzCJcBnaouCNESWrFMSj3zrjrjjtpjEssAIVnBhgvO7iiKgEBDE= X-Google-Smtp-Source: AGHT+IEmVpurGUd31yZyHxSu4mjLVka0+r+yTrQMWzelFcoJ23tJQXn1JppRqRT3evd2Ke2EuGrRpg== X-Received: by 2002:a81:8784:0:b0:608:290d:9f1b with SMTP id x126-20020a818784000000b00608290d9f1bmr14538562ywf.49.1709755197926; Wed, 06 Mar 2024 11:59:57 -0800 (PST) Received: from localhost (076-182-020-124.res.spectrum.com. [76.182.20.124]) by smtp.gmail.com with ESMTPSA id r13-20020ac85e8d000000b0042f02284578sm1888194qtx.68.2024.03.06.11.59.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Mar 2024 11:59:57 -0800 (PST) Date: Wed, 6 Mar 2024 14:59:56 -0500 From: Josef Bacik To: Christian Brauner Cc: Kent Overstreet , linux-bcachefs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Miklos Szeredi , David Howells Subject: Re: [PATCH] statx: stx_vol Message-ID: <20240306195956.GA2420648@perftesting> References: <20240302220203.623614-1-kent.overstreet@linux.dev> <20240304-konfus-neugierig-5c7c9d5a8ad6@brauner> Precedence: bulk X-Mailing-List: linux-bcachefs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240304-konfus-neugierig-5c7c9d5a8ad6@brauner> On Mon, Mar 04, 2024 at 10:18:22AM +0100, Christian Brauner wrote: > On Sat, Mar 02, 2024 at 05:02:03PM -0500, Kent Overstreet wrote: > > Add a new statx field for (sub)volume identifiers. > > > > This includes bcachefs support; we'll definitely want btrfs support as > > well. > > > > Link: https://lore.kernel.org/linux-fsdevel/2uvhm6gweyl7iyyp2xpfryvcu2g3padagaeqcbiavjyiis6prl@yjm725bizncq/ > > Signed-off-by: Kent Overstreet > > Cc: Josef Bacik > > Cc: Miklos Szeredi > > Cc: Christian Brauner > > Cc: David Howells > > --- > > As I've said many times before I'm supportive of this and would pick up > a patch like this. There's definitely a lot of userspace that would make > use of this that I'm aware of. If the btrfs people could provide an Ack > on this to express their support here that would be great. > > And it would be lovely if we could expand the commit message a bit and > do some renaming/bikeshedding. Imho, STATX_SUBVOLUME_ID is great and > then stx_subvolume_id or stx_subvol_id. And then subvolume_id or > subvol_id for the field in struct kstat. Sorry I had my head down in some NFS problems. This works for me, I agree with the naming suggestions you've made. Kent, when you send a new version I'll review it and then followup with a btrfs patch. Thanks for getting this ball rolling, Josef