[PATCH v2 00/15] treewide: Refactor heap related implementation

Kuan-Wei Chiu
2024-03-20T14:54:25Z

This patch series focuses on several adjustments related to heap
implementation. Firstly, a type-safe interface has been added to the
min_heap, along with the introduction of several new functions to
enhance its functionality. Additionally, the heap implementation for
bcache and bcachefs has been replaced with the generic min_heap
implementation from include/linux. Furthermore, several typos have been
corrected.

Previous discussion with Kent Overstreet:
https://lkml.kernel.org/ioyfizrzq7w7mjrqcadtzsfgpuntowtjdw5pgn4qhvsdp4mqqg@nrlek5vmisbu

Regards,
Kuan-Wei

---

You can preview this patch series on the 'refactor-heap-v2' branch of
the repository at the following link:

https://github.com/visitorckw/linux.git

Changes in v2:
- Add attribute __always_unused to the compare and swap functions
that do not use the args parameter.
- Rename min_heapify() to min_heap_sift_down().
- Update lib/test_min_heap.c to use min_heap_init().
- Refine the commit message for bcache and bcachefs.
- Adjust the order of patches in the patch series.

Link to v1: https://lkml.kernel.org/20240319180005.246930-1-visitorckw@gmail.com

Kuan-Wei Chiu (15):
perf/core: Fix several typos
bcache: Fix typo
bcachefs: Fix typo
lib min_heap: Add type safe interface
lib min_heap: Add min_heap_init()
lib min_heap: Add min_heap_peek()
lib min_heap: Add min_heap_full()
lib min_heap: Add min_heap_del()
lib min_heap: Add min_heap_sift_up()
lib min_heap: Add args for min_heap_callbacks
lib min_heap: Update min_heap_push() and min_heap_pop() to return bool
values
lib min_heap: Rename min_heapify() to min_heap_sift_down()
lib/test_min_heap: Use min_heap_init() for initializing
bcache: Remove heap-related macros and switch to generic min_heap
bcachefs: Remove heap-related macros and switch to generic min_heap

drivers/md/bcache/alloc.c | 66 ++++++++----
drivers/md/bcache/bcache.h | 2 +-
drivers/md/bcache/bset.c | 73 ++++++++-----
drivers/md/bcache/bset.h | 38 ++++---
drivers/md/bcache/btree.c | 27 ++++-
drivers/md/bcache/extents.c | 44 ++++----
drivers/md/bcache/movinggc.c | 40 ++++++--
drivers/md/bcache/super.c | 16 +++
drivers/md/bcache/sysfs.c | 3 +
drivers/md/bcache/util.c | 2 +-
drivers/md/bcache/util.h | 81 +--------------
drivers/md/dm-vdo/repair.c | 29 +++---
drivers/md/dm-vdo/slab-depot.c | 22 ++--
fs/bcachefs/clock.c | 53 +++++++---
fs/bcachefs/clock_types.h | 2 +-
fs/bcachefs/ec.c | 100 +++++++++++-------
fs/bcachefs/ec_types.h | 2 +-
fs/bcachefs/util.c | 2 +-
fs/bcachefs/util.h | 127 ++---------------------
include/linux/min_heap.h | 180 ++++++++++++++++++++++++++-------
kernel/events/core.c | 53 +++++-----
lib/test_min_heap.c | 70 ++++++-------
22 files changed, 562 insertions(+), 470 deletions(-)

--
2.34.1