Re: [PATCH 1/2] bcachefs: do not use PF_MEMALLOC_NORECLAIM

kernel test robot
2024-09-05T09:29:26Z

Hi Michal,

kernel test robot noticed the following build warnings:

[auto build test WARNING on akpm-mm/mm-everything]
[also build test WARNING on tip/sched/core brauner-vfs/vfs.all linus/master v6.11-rc6]
[cannot apply to next-20240904]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Michal-Hocko/bcachefs-do-not-use-PF_MEMALLOC_NORECLAIM/20240902-200126
base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
patch link: https://lore.kernel.org/r/20240902095203.1559361-2-mhocko%40kernel.org
patch subject: [PATCH 1/2] bcachefs: do not use PF_MEMALLOC_NORECLAIM
config: x86_64-allnoconfig (https://download.01.org/0day-ci/archive/20240905/202409051713.LFVMScXi-lkp@intel.com/config)
compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project 617a15a9eac96088ae5e9134248d8236e34b91b1)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240905/202409051713.LFVMScXi-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202409051713.LFVMScXi-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> fs/inode.c:157: warning: Function parameter or struct member 'gfp' not described in 'inode_init_always_gfp'
>> fs/inode.c:157: warning: expecting prototype for inode_init_always(). Prototype was for inode_init_always_gfp() instead

vim +157 fs/inode.c

bd9b51e79cb0b8 Al Viro 2014-11-18 147
2cb1599f9b2ecd David Chinner 2008-10-30 148 /**
6e7c2b4dd36d83 Masahiro Yamada 2017-05-08 149 * inode_init_always - perform inode structure initialisation
0bc02f3fa433a9 Randy Dunlap 2009-01-06 150 * @sb: superblock inode belongs to
0bc02f3fa433a9 Randy Dunlap 2009-01-06 151 * @inode: inode to initialise
2cb1599f9b2ecd David Chinner 2008-10-30 152 *
2cb1599f9b2ecd David Chinner 2008-10-30 153 * These are initializations that need to be done on every inode
2cb1599f9b2ecd David Chinner 2008-10-30 154 * allocation as the fields are not initialised by slab allocation.
2cb1599f9b2ecd David Chinner 2008-10-30 155 */
6185335c11aac8 Michal Hocko 2024-09-02 156 int inode_init_always_gfp(struct super_block *sb, struct inode *inode, gfp_t gfp)
^1da177e4c3f41 Linus Torvalds 2005-04-16 @157 {
6e1d5dcc2bbbe7 Alexey Dobriyan 2009-09-21 158 static const struct inode_operations empty_iops;
bd9b51e79cb0b8 Al Viro 2014-11-18 159 static const struct file_operations no_open_fops = {.open = no_open};
^1da177e4c3f41 Linus Torvalds 2005-04-16 160 struct address_space *const mapping = &inode->i_data;
^1da177e4c3f41 Linus Torvalds 2005-04-16 161
^1da177e4c3f41 Linus Torvalds 2005-04-16 162 inode->i_sb = sb;
^1da177e4c3f41 Linus Torvalds 2005-04-16 163 inode->i_blkbits = sb->s_blocksize_bits;
^1da177e4c3f41 Linus Torvalds 2005-04-16 164 inode->i_flags = 0;
5a9b911b8a24ed Mateusz Guzik 2024-06-11 165 inode->i_state = 0;
8019ad13ef7f64 Peter Zijlstra 2020-03-04 166 atomic64_set(&inode->i_sequence, 0);
^1da177e4c3f41 Linus Torvalds 2005-04-16 167 atomic_set(&inode->i_count, 1);
^1da177e4c3f41 Linus Torvalds 2005-04-16 168 inode->i_op = &empty_iops;
bd9b51e79cb0b8 Al Viro 2014-11-18 169 inode->i_fop = &no_open_fops;
edbb35cc6bdfc3 Eric Biggers 2020-10-30 170 inode->i_ino = 0;
a78ef704a8dd43 Miklos Szeredi 2011-10-28 171 inode->__i_nlink = 1;
3ddcd0569cd68f Linus Torvalds 2011-08-06 172 inode->i_opflags = 0;
d0a5b995a30834 Andreas Gruenbacher 2016-09-29 173 if (sb->s_xattr)
d0a5b995a30834 Andreas Gruenbacher 2016-09-29 174 inode->i_opflags |= IOP_XATTR;
92361636e0153b Eric W. Biederman 2012-02-08 175 i_uid_write(inode, 0);
92361636e0153b Eric W. Biederman 2012-02-08 176 i_gid_write(inode, 0);
^1da177e4c3f41 Linus Torvalds 2005-04-16 177 atomic_set(&inode->i_writecount, 0);
^1da177e4c3f41 Linus Torvalds 2005-04-16 178 inode->i_size = 0;
c75b1d9421f80f Jens Axboe 2017-06-27 179 inode->i_write_hint = WRITE_LIFE_NOT_SET;
^1da177e4c3f41 Linus Torvalds 2005-04-16 180 inode->i_blocks = 0;
^1da177e4c3f41 Linus Torvalds 2005-04-16 181 inode->i_bytes = 0;
^1da177e4c3f41 Linus Torvalds 2005-04-16 182 inode->i_generation = 0;
^1da177e4c3f41 Linus Torvalds 2005-04-16 183 inode->i_pipe = NULL;
^1da177e4c3f41 Linus Torvalds 2005-04-16 184 inode->i_cdev = NULL;
61ba64fc076887 Al Viro 2015-05-02 185 inode->i_link = NULL;
84e710da2a1dfa Al Viro 2016-04-15 186 inode->i_dir_seq = 0;
^1da177e4c3f41 Linus Torvalds 2005-04-16 187 inode->i_rdev = 0;
^1da177e4c3f41 Linus Torvalds 2005-04-16 188 inode->dirtied_when = 0;
6146f0d5e47ca4 Mimi Zohar 2009-02-04 189

--
0-DAY CI Kernel Test Service