From: David Disseldorp <ddiss@suse.de>
To: Kent Overstreet <kent.overstreet@linux.dev>
Cc: Hongbo Li <lihongbo22@huawei.com>,
linux-bcachefs@vger.kernel.org, liaochang1@huawei.com
Subject: Re: [PATCH] bcachefs: fix incorrect show_options results
Date: Tue, 24 Sep 2024 02:52:42 +0000 [thread overview]
Message-ID: <20240924025242.39f29fe8.ddiss@suse.de> (raw)
In-Reply-To: <sufy3jfju76sqh4eplc5hmsrfrpa4dtt3bocovfeygxclkvgql@ukd2pvvxn5jr>
On Mon, 23 Sep 2024 17:40:05 -0400, Kent Overstreet wrote:
> On Mon, Sep 23, 2024 at 02:39:31PM GMT, David Disseldorp wrote:
...
> > > int ret = buf.allocation_failure ? -ENOMEM : 0;
> >
> > Should the copy from buf into seq occur if allocation_failure
> > is already flagged? I'd expect seq_puts() to have oopsed.
>
> That's a good point; it might be the first allocation that fails, not a
> realloc. It won't be in practice, buuuut....
I've sent a follow-up patch to avoid the seq_puts(seq, NULL). Feel free
to squash it in with this if you like.
next prev parent reply other threads:[~2024-09-24 2:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-23 9:50 [PATCH] bcachefs: fix incorrect show_options results Hongbo Li
2024-09-23 14:39 ` David Disseldorp
2024-09-23 21:40 ` Kent Overstreet
2024-09-24 2:52 ` David Disseldorp [this message]
2024-09-24 1:29 ` Hongbo Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240924025242.39f29fe8.ddiss@suse.de \
--to=ddiss@suse.de \
--cc=kent.overstreet@linux.dev \
--cc=liaochang1@huawei.com \
--cc=lihongbo22@huawei.com \
--cc=linux-bcachefs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox