From: Jeongjun Park <aha310510@gmail.com>
To: kent.overstreet@linux.dev, mmpgouride@gmail.com
Cc: linux-bcachefs@vger.kernel.org, linux-kernel@vger.kernel.org,
syzbot+7f45fa9805c40db3f108@syzkaller.appspotmail.com,
Jeongjun Park <aha310510@gmail.com>
Subject: [PATCH v3] bcachefs: fix shift oob in alloc_lru_idx_fragmentation
Date: Tue, 22 Oct 2024 00:43:56 +0900 [thread overview]
Message-ID: <20241021154356.38221-1-aha310510@gmail.com> (raw)
The size of a.data_type is set abnormally large, causing shift-out-of-bounds.
To fix this, we need to add validation on a.data_type in
alloc_lru_idx_fragmentation().
Reported-by: syzbot+7f45fa9805c40db3f108@syzkaller.appspotmail.com
Fixes: 260af1562ec1 ("bcachefs: Kill alloc_v4.fragmentation_lru")
Signed-off-by: Jeongjun Park <aha310510@gmail.com>
---
fs/bcachefs/alloc_background.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/fs/bcachefs/alloc_background.h b/fs/bcachefs/alloc_background.h
index f8e87c6721b1..163a67b97a40 100644
--- a/fs/bcachefs/alloc_background.h
+++ b/fs/bcachefs/alloc_background.h
@@ -168,6 +168,9 @@ static inline bool data_type_movable(enum bch_data_type type)
static inline u64 alloc_lru_idx_fragmentation(struct bch_alloc_v4 a,
struct bch_dev *ca)
{
+ if (a.data_type >= BCH_DATA_NR)
+ return 0;
+
if (!data_type_movable(a.data_type) ||
!bch2_bucket_sectors_fragmented(ca, a))
return 0;
--
next reply other threads:[~2024-10-21 15:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-21 15:43 Jeongjun Park [this message]
2024-10-22 2:26 ` [PATCH v3] bcachefs: fix shift oob in alloc_lru_idx_fragmentation Hongbo Li
2024-10-22 2:38 ` Alan Huang
2024-10-22 3:05 ` Hongbo Li
2024-10-22 3:23 ` Alan Huang
2024-10-22 4:05 ` Jeongjun Park
2024-10-23 1:11 ` Hongbo Li
2024-10-24 11:30 ` Kent Overstreet
2024-10-24 11:30 ` Kent Overstreet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241021154356.38221-1-aha310510@gmail.com \
--to=aha310510@gmail.com \
--cc=kent.overstreet@linux.dev \
--cc=linux-bcachefs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmpgouride@gmail.com \
--cc=syzbot+7f45fa9805c40db3f108@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox