* [PATCH] bcachefs: fix null-ptr-deref in have_stripes()
@ 2024-10-23 16:13 Jeongjun Park
2024-10-24 2:37 ` Kent Overstreet
0 siblings, 1 reply; 2+ messages in thread
From: Jeongjun Park @ 2024-10-23 16:13 UTC (permalink / raw)
To: kent.overstreet
Cc: linux-bcachefs, linux-kernel, syzbot+b468b9fef56949c3b528,
Jeongjun Park
c->btree_roots_known[i].b can be NULL. In this case, a NULL pointer dereference
occurs, so you need to add code to check the variable.
Reported-by: syzbot+b468b9fef56949c3b528@syzkaller.appspotmail.com
Fixes: ("bcachefs: metadata version bucket_stripe_sectors")
Signed-off-by: Jeongjun Park <aha310510@gmail.com>
---
fs/bcachefs/sb-downgrade.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/fs/bcachefs/sb-downgrade.c b/fs/bcachefs/sb-downgrade.c
index ae715ff658e8..8767c33c2b51 100644
--- a/fs/bcachefs/sb-downgrade.c
+++ b/fs/bcachefs/sb-downgrade.c
@@ -143,6 +143,9 @@ UPGRADE_TABLE()
static int have_stripes(struct bch_fs *c)
{
+ if (IS_ERR_OR_NULL(c->btree_roots_known[BTREE_ID_stripes].b))
+ return 0;
+
return !btree_node_fake(c->btree_roots_known[BTREE_ID_stripes].b);
}
--
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] bcachefs: fix null-ptr-deref in have_stripes()
2024-10-23 16:13 [PATCH] bcachefs: fix null-ptr-deref in have_stripes() Jeongjun Park
@ 2024-10-24 2:37 ` Kent Overstreet
0 siblings, 0 replies; 2+ messages in thread
From: Kent Overstreet @ 2024-10-24 2:37 UTC (permalink / raw)
To: Jeongjun Park; +Cc: linux-bcachefs, linux-kernel, syzbot+b468b9fef56949c3b528
On Thu, Oct 24, 2024 at 01:13:45AM +0900, Jeongjun Park wrote:
> c->btree_roots_known[i].b can be NULL. In this case, a NULL pointer dereference
> occurs, so you need to add code to check the variable.
>
> Reported-by: syzbot+b468b9fef56949c3b528@syzkaller.appspotmail.com
> Fixes: ("bcachefs: metadata version bucket_stripe_sectors")
> Signed-off-by: Jeongjun Park <aha310510@gmail.com>
Thanks, applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-10-24 2:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-23 16:13 [PATCH] bcachefs: fix null-ptr-deref in have_stripes() Jeongjun Park
2024-10-24 2:37 ` Kent Overstreet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox