[PATCH] bcachefs: Explicitly select CRYPTO from BCACHEFS_FS

[PATCH] bcachefs: Explicitly select CRYPTO from BCACHEFS_FS

[Eric Biggers]

From: Eric Biggers <ebiggers@google.com>

Explicitly select CRYPTO from BCACHEFS_FS, so that this dependency of
CRYPTO_SHA256, CRYPTO_CHACHA20, and CRYPTO_POLY1305 (which are also
selected) is satisfied.  Currently this dependency is satisfied
indirectly via LIBCRC32C, but this is fragile and is planned to change
(https://lore.kernel.org/r/20241021002935.325878-13-ebiggers@kernel.org).

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202410232254.ogS6Em2d-lkp@intel.com/
Signed-off-by: Eric Biggers <ebiggers@google.com>
---
 fs/bcachefs/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/bcachefs/Kconfig b/fs/bcachefs/Kconfig
index 5bac803ea367c..a61b22c142a19 100644
--- a/fs/bcachefs/Kconfig
+++ b/fs/bcachefs/Kconfig
@@ -13,10 +13,11 @@ config BCACHEFS_FS
 	select LZ4HC_DECOMPRESS
 	select ZLIB_DEFLATE
 	select ZLIB_INFLATE
 	select ZSTD_COMPRESS
 	select ZSTD_DECOMPRESS
+	select CRYPTO
 	select CRYPTO_SHA256
 	select CRYPTO_CHACHA20
 	select CRYPTO_POLY1305
 	select KEYS
 	select RAID6_PQ

base-commit: 42f7652d3eb527d03665b09edac47f85fb600924
-- 
2.47.0.163.g1226f6d8fa-goog

Re: [PATCH] bcachefs: Explicitly select CRYPTO from BCACHEFS_FS

[Kent Overstreet]

On Wed, Oct 23, 2024 at 06:35:21PM +0000, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
> 
> Explicitly select CRYPTO from BCACHEFS_FS, so that this dependency of
> CRYPTO_SHA256, CRYPTO_CHACHA20, and CRYPTO_POLY1305 (which are also
> selected) is satisfied.  Currently this dependency is satisfied
> indirectly via LIBCRC32C, but this is fragile and is planned to change
> (https://lore.kernel.org/r/20241021002935.325878-13-ebiggers@kernel.org).
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202410232254.ogS6Em2d-lkp@intel.com/
> Signed-off-by: Eric Biggers <ebiggers@google.com>

Thanks, applied

(or acked-by, if you want to take it through your tree?)

Re: [PATCH] bcachefs: Explicitly select CRYPTO from BCACHEFS_FS

[Eric Biggers]

On Wed, Oct 23, 2024 at 02:49:38PM -0400, Kent Overstreet wrote:
> On Wed, Oct 23, 2024 at 06:35:21PM +0000, Eric Biggers wrote:
> > From: Eric Biggers <ebiggers@google.com>
> > 
> > Explicitly select CRYPTO from BCACHEFS_FS, so that this dependency of
> > CRYPTO_SHA256, CRYPTO_CHACHA20, and CRYPTO_POLY1305 (which are also
> > selected) is satisfied.  Currently this dependency is satisfied
> > indirectly via LIBCRC32C, but this is fragile and is planned to change
> > (https://lore.kernel.org/r/20241021002935.325878-13-ebiggers@kernel.org).
> > 
> > Reported-by: kernel test robot <lkp@intel.com>
> > Closes: https://lore.kernel.org/oe-kbuild-all/202410232254.ogS6Em2d-lkp@intel.com/
> > Signed-off-by: Eric Biggers <ebiggers@google.com>
> 
> Thanks, applied
> 
> (or acked-by, if you want to take it through your tree?)

Please go ahead and take it.  It will take a while to get my patchset merged,
and it will help to get dependencies like this out of the way first.  Thanks!

- Eric