* [PATCH] bcachefs-tools: Fix TODO "Show bcachefs version"
@ 2024-11-05 8:36 Integral
2024-11-06 21:21 ` Kent Overstreet
0 siblings, 1 reply; 2+ messages in thread
From: Integral @ 2024-11-05 8:36 UTC (permalink / raw)
To: kent.overstreet, lihongbo22; +Cc: mmpgouride, linux-bcachefs, integral
Fix TODO "Show bcachefs version" in fusemount.
Signed-off-by: Integral <integral@archlinuxcn.org>
---
c_src/cmd_fusemount.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/c_src/cmd_fusemount.c b/c_src/cmd_fusemount.c
index babdb6fb..e5674b42 100644
--- a/c_src/cmd_fusemount.c
+++ b/c_src/cmd_fusemount.c
@@ -1222,9 +1222,9 @@ int cmd_fusemount(int argc, char *argv[])
goto out;
}
if (fuse_opts.show_version) {
- /* TODO: Show bcachefs version. */
printf("FUSE library version %s\n", fuse_pkgversion());
fuse_lowlevel_version();
+ printf("bcachefs version: %s\n", VERSION_STRING);
ret = 0;
goto out;
}
--
2.47.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] bcachefs-tools: Fix TODO "Show bcachefs version"
2024-11-05 8:36 [PATCH] bcachefs-tools: Fix TODO "Show bcachefs version" Integral
@ 2024-11-06 21:21 ` Kent Overstreet
0 siblings, 0 replies; 2+ messages in thread
From: Kent Overstreet @ 2024-11-06 21:21 UTC (permalink / raw)
To: Integral; +Cc: kent.overstreet, lihongbo22, mmpgouride, linux-bcachefs
On Tue, Nov 05, 2024 at 04:36:01PM +0800, Integral wrote:
> Fix TODO "Show bcachefs version" in fusemount.
>
> Signed-off-by: Integral <integral@archlinuxcn.org>
Applied
> ---
> c_src/cmd_fusemount.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/c_src/cmd_fusemount.c b/c_src/cmd_fusemount.c
> index babdb6fb..e5674b42 100644
> --- a/c_src/cmd_fusemount.c
> +++ b/c_src/cmd_fusemount.c
> @@ -1222,9 +1222,9 @@ int cmd_fusemount(int argc, char *argv[])
> goto out;
> }
> if (fuse_opts.show_version) {
> - /* TODO: Show bcachefs version. */
> printf("FUSE library version %s\n", fuse_pkgversion());
> fuse_lowlevel_version();
> + printf("bcachefs version: %s\n", VERSION_STRING);
> ret = 0;
> goto out;
> }
> --
> 2.47.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-11-06 21:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-05 8:36 [PATCH] bcachefs-tools: Fix TODO "Show bcachefs version" Integral
2024-11-06 21:21 ` Kent Overstreet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox