* [PATCH] objtool: Add bch2_trans_unlocked_or_in_restart_error() to bcachefs noreturns
@ 2025-02-18 6:42 Youling Tang
2025-02-20 22:08 ` Josh Poimboeuf
2025-02-20 23:22 ` Kent Overstreet
0 siblings, 2 replies; 3+ messages in thread
From: Youling Tang @ 2025-02-18 6:42 UTC (permalink / raw)
To: Josh Poimboeuf, Peter Zijlstra
Cc: Kent Overstreet, linux-kernel, linux-bcachefs, youling.tang, k2ci,
Youling Tang
From: Youling Tang <tangyouling@kylinos.cn>
Fix the following objtool warning during build time:
fs/bcachefs/btree_cache.o: warning: objtool: btree_node_lock.constprop.0() falls through to next function bch2_recalc_btree_reserve()
fs/bcachefs/btree_update.o: warning: objtool: bch2_trans_update_get_key_cache() falls through to next function need_whiteout_for_snapshot()
bch2_trans_unlocked_or_in_restart_error() is an Obviously Correct (tm)
panic() wrapper, add it to the list of known noreturns.
Fixes: b318882022a8 ("bcachefs: bch2_trans_verify_not_unlocked_or_in_restart()")
Reported-by: k2ci<kernel-bot@kylinos.cn>
Signed-off-by: Youling Tang <tangyouling@kylinos.cn>
---
tools/objtool/noreturns.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/objtool/noreturns.h b/tools/objtool/noreturns.h
index b2174894f9f7..6bb7edda3094 100644
--- a/tools/objtool/noreturns.h
+++ b/tools/objtool/noreturns.h
@@ -19,7 +19,7 @@ NORETURN(__x64_sys_exit_group)
NORETURN(arch_cpu_idle_dead)
NORETURN(bch2_trans_in_restart_error)
NORETURN(bch2_trans_restart_error)
-NORETURN(bch2_trans_unlocked_error)
+NORETURN(bch2_trans_unlocked_or_in_restart_error)
NORETURN(cpu_bringup_and_idle)
NORETURN(cpu_startup_entry)
NORETURN(do_exit)
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] objtool: Add bch2_trans_unlocked_or_in_restart_error() to bcachefs noreturns
2025-02-18 6:42 [PATCH] objtool: Add bch2_trans_unlocked_or_in_restart_error() to bcachefs noreturns Youling Tang
@ 2025-02-20 22:08 ` Josh Poimboeuf
2025-02-20 23:22 ` Kent Overstreet
1 sibling, 0 replies; 3+ messages in thread
From: Josh Poimboeuf @ 2025-02-20 22:08 UTC (permalink / raw)
To: Youling Tang
Cc: Peter Zijlstra, Kent Overstreet, linux-kernel, linux-bcachefs,
k2ci, Youling Tang
On Tue, Feb 18, 2025 at 02:42:30PM +0800, Youling Tang wrote:
> From: Youling Tang <tangyouling@kylinos.cn>
>
> Fix the following objtool warning during build time:
> fs/bcachefs/btree_cache.o: warning: objtool: btree_node_lock.constprop.0() falls through to next function bch2_recalc_btree_reserve()
> fs/bcachefs/btree_update.o: warning: objtool: bch2_trans_update_get_key_cache() falls through to next function need_whiteout_for_snapshot()
>
> bch2_trans_unlocked_or_in_restart_error() is an Obviously Correct (tm)
> panic() wrapper, add it to the list of known noreturns.
>
> Fixes: b318882022a8 ("bcachefs: bch2_trans_verify_not_unlocked_or_in_restart()")
> Reported-by: k2ci<kernel-bot@kylinos.cn>
> Signed-off-by: Youling Tang <tangyouling@kylinos.cn>
Acked-by: Josh Poimboeuf <jpoimboe@kernel.org>
Peter, can you take this one?
--
Josh
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] objtool: Add bch2_trans_unlocked_or_in_restart_error() to bcachefs noreturns
2025-02-18 6:42 [PATCH] objtool: Add bch2_trans_unlocked_or_in_restart_error() to bcachefs noreturns Youling Tang
2025-02-20 22:08 ` Josh Poimboeuf
@ 2025-02-20 23:22 ` Kent Overstreet
1 sibling, 0 replies; 3+ messages in thread
From: Kent Overstreet @ 2025-02-20 23:22 UTC (permalink / raw)
To: Youling Tang
Cc: Josh Poimboeuf, Peter Zijlstra, linux-kernel, linux-bcachefs,
k2ci, Youling Tang
On Tue, Feb 18, 2025 at 02:42:30PM +0800, Youling Tang wrote:
> From: Youling Tang <tangyouling@kylinos.cn>
>
> Fix the following objtool warning during build time:
> fs/bcachefs/btree_cache.o: warning: objtool: btree_node_lock.constprop.0() falls through to next function bch2_recalc_btree_reserve()
> fs/bcachefs/btree_update.o: warning: objtool: bch2_trans_update_get_key_cache() falls through to next function need_whiteout_for_snapshot()
>
> bch2_trans_unlocked_or_in_restart_error() is an Obviously Correct (tm)
> panic() wrapper, add it to the list of known noreturns.
>
> Fixes: b318882022a8 ("bcachefs: bch2_trans_verify_not_unlocked_or_in_restart()")
> Reported-by: k2ci<kernel-bot@kylinos.cn>
> Signed-off-by: Youling Tang <tangyouling@kylinos.cn>
Reviewed-by: Kent Overstreet <kent.overstreet@linux.dev>
> ---
> tools/objtool/noreturns.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/objtool/noreturns.h b/tools/objtool/noreturns.h
> index b2174894f9f7..6bb7edda3094 100644
> --- a/tools/objtool/noreturns.h
> +++ b/tools/objtool/noreturns.h
> @@ -19,7 +19,7 @@ NORETURN(__x64_sys_exit_group)
> NORETURN(arch_cpu_idle_dead)
> NORETURN(bch2_trans_in_restart_error)
> NORETURN(bch2_trans_restart_error)
> -NORETURN(bch2_trans_unlocked_error)
> +NORETURN(bch2_trans_unlocked_or_in_restart_error)
> NORETURN(cpu_bringup_and_idle)
> NORETURN(cpu_startup_entry)
> NORETURN(do_exit)
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-02-20 23:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-18 6:42 [PATCH] objtool: Add bch2_trans_unlocked_or_in_restart_error() to bcachefs noreturns Youling Tang
2025-02-20 22:08 ` Josh Poimboeuf
2025-02-20 23:22 ` Kent Overstreet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox