From: Alan Huang <mmpgouride@gmail.com>
To: kent.overstreet@linux.dev
Cc: linux-bcachefs@vger.kernel.org, Alan Huang <mmpgouride@gmail.com>
Subject: [PATCH 1/4] bcachefs: Kill bch2_trans_unlock_noassert
Date: Tue, 15 Apr 2025 13:33:04 +0800 [thread overview]
Message-ID: <20250415053307.81354-2-mmpgouride@gmail.com> (raw)
In-Reply-To: <20250415053307.81354-1-mmpgouride@gmail.com>
Signed-off-by: Alan Huang <mmpgouride@gmail.com>
---
fs/bcachefs/btree_cache.c | 2 +-
fs/bcachefs/btree_locking.c | 7 -------
fs/bcachefs/btree_locking.h | 1 -
3 files changed, 1 insertion(+), 9 deletions(-)
diff --git a/fs/bcachefs/btree_cache.c b/fs/bcachefs/btree_cache.c
index 9b80201c7982..153980a9a1cc 100644
--- a/fs/bcachefs/btree_cache.c
+++ b/fs/bcachefs/btree_cache.c
@@ -978,7 +978,7 @@ static noinline struct btree *bch2_btree_node_fill(struct btree_trans *trans,
/* Unlock before doing IO: */
six_unlock_intent(&b->c.lock);
- bch2_trans_unlock_noassert(trans);
+ bch2_trans_unlock(trans);
bch2_btree_node_read(trans, b, sync);
diff --git a/fs/bcachefs/btree_locking.c b/fs/bcachefs/btree_locking.c
index 94eb2b73a843..f4f563944340 100644
--- a/fs/bcachefs/btree_locking.c
+++ b/fs/bcachefs/btree_locking.c
@@ -799,13 +799,6 @@ int bch2_trans_relock_notrace(struct btree_trans *trans)
return __bch2_trans_relock(trans, false);
}
-void bch2_trans_unlock_noassert(struct btree_trans *trans)
-{
- __bch2_trans_unlock(trans);
-
- trans_set_unlocked(trans);
-}
-
void bch2_trans_unlock(struct btree_trans *trans)
{
__bch2_trans_unlock(trans);
diff --git a/fs/bcachefs/btree_locking.h b/fs/bcachefs/btree_locking.h
index b33ab7af8440..66b27c0853a5 100644
--- a/fs/bcachefs/btree_locking.h
+++ b/fs/bcachefs/btree_locking.h
@@ -15,7 +15,6 @@
void bch2_btree_lock_init(struct btree_bkey_cached_common *, enum six_lock_init_flags, gfp_t gfp);
-void bch2_trans_unlock_noassert(struct btree_trans *);
void bch2_trans_unlock_write(struct btree_trans *);
static inline bool is_btree_node(struct btree_path *path, unsigned l)
--
2.48.1
next prev parent reply other threads:[~2025-04-15 5:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-15 5:33 [PATCH 0/4] bcachefs: Random cleanup Alan Huang
2025-04-15 5:33 ` Alan Huang [this message]
2025-04-15 14:34 ` [PATCH 1/4] bcachefs: Kill bch2_trans_unlock_noassert Kent Overstreet
2025-04-15 5:33 ` [PATCH 2/4] bcachefs: mark_btree_node_locked_noreset -> mark_btree_node_locked_reset Alan Huang
2025-04-15 14:34 ` Kent Overstreet
2025-04-15 14:40 ` Alan Huang
2025-04-15 15:10 ` Kent Overstreet
2025-04-15 5:33 ` [PATCH 3/4] bcachefs: Remove spurious +1/-1 operation Alan Huang
2025-04-15 14:35 ` Kent Overstreet
2025-04-15 5:33 ` [PATCH 4/4] bcachefs: Simplify logic Alan Huang
2025-04-15 14:36 ` Kent Overstreet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250415053307.81354-2-mmpgouride@gmail.com \
--to=mmpgouride@gmail.com \
--cc=kent.overstreet@linux.dev \
--cc=linux-bcachefs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox