Linux bcachefs list
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Kent Overstreet <kent.overstreet@linux.dev>,
	linux-bcachefs@vger.kernel.org
Subject: Unused trace events in bcachefs
Date: Thu, 12 Jun 2025 22:40:59 -0400	[thread overview]
Message-ID: <20250612224059.39fddd07@batman.local.home> (raw)

I have code that will trigger a warning if a trace event is defined but
not used[1]. It gives a list of unused events. Here's what I have for
bcachefs:

warning: tracepoint 'trans_restart_journal_preres_get' is unused.
warning: tracepoint 'trans_restart_fault_inject' is unused.
warning: tracepoint 'trans_restart_relock_after_fill' is unused.
warning: tracepoint 'trans_restart_key_cache_upgrade' is unused.
warning: tracepoint 'trans_restart_relock_key_cache_fill' is unused.
warning: tracepoint 'trans_restart_traverse' is unused.
warning: tracepoint 'trans_restart_key_cache_key_realloced' is unused.
warning: tracepoint 'trans_restart_write_buffer_flush' is unused.
warning: tracepoint 'btree_path_free_trans_begin' is unused.

Each trace event can take up to around 5K in memory regardless if they
are used or not. Soon there will be warnings when they are defined but
not used. Please remove any unused trace event or at least hide it
under an #ifdef if they are used within configs. I'm planning on adding
these warning in the next merge window.

Thanks,

-- Steve

[1] https://lore.kernel.org/linux-trace-kernel/20250612235827.011358765@goodmis.org/

                 reply	other threads:[~2025-06-13  2:41 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250612224059.39fddd07@batman.local.home \
    --to=rostedt@goodmis.org \
    --cc=kent.overstreet@linux.dev \
    --cc=linux-bcachefs@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox