[PATCH] bcachefs: Convert comma to semicolon

[PATCH] bcachefs: Convert comma to semicolon

[Chen Ni]

Replace a comma between expression statements by a semicolon.

Fixes: 79032b078173 ("bcachefs: Improved topology repair checks")
Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
 fs/bcachefs/btree_update_interior.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/bcachefs/btree_update_interior.c b/fs/bcachefs/btree_update_interior.c
index 31ee50184be2..51b43d75ddb6 100644
--- a/fs/bcachefs/btree_update_interior.c
+++ b/fs/bcachefs/btree_update_interior.c
@@ -96,7 +96,7 @@ int bch2_btree_node_check_topology(struct btree_trans *trans, struct btree *b)
 			bch2_topology_error(c);
 
 			printbuf_reset(&buf);
-			prt_str(&buf, "end of prev node doesn't match start of next node\n"),
+			prt_str(&buf, "end of prev node doesn't match start of next node\n");
 			prt_printf(&buf, "  in btree %s level %u node ",
 				   bch2_btree_id_str(b->c.btree_id), b->c.level);
 			bch2_bkey_val_to_text(&buf, c, bkey_i_to_s_c(&b->key));
-- 
2.25.1

Re: [PATCH] bcachefs: Convert comma to semicolon

[Hongbo Li]

On 2024/7/16 12:03, Chen Ni wrote:
> Replace a comma between expression statements by a semicolon.
> 
> Fixes: 79032b078173 ("bcachefs: Improved topology repair checks")
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> ---
>   fs/bcachefs/btree_update_interior.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/bcachefs/btree_update_interior.c b/fs/bcachefs/btree_update_interior.c
> index 31ee50184be2..51b43d75ddb6 100644
> --- a/fs/bcachefs/btree_update_interior.c
> +++ b/fs/bcachefs/btree_update_interior.c
> @@ -96,7 +96,7 @@ int bch2_btree_node_check_topology(struct btree_trans *trans, struct btree *b)
>   			bch2_topology_error(c);
>   
>   			printbuf_reset(&buf);
> -			prt_str(&buf, "end of prev node doesn't match start of next node\n"),
> +			prt_str(&buf, "end of prev node doesn't match start of next node\n");

Reviewed-by: Hongbo Li <lihongbo22@huawei.com>

Thanks,
Hongbo
>   			prt_printf(&buf, "  in btree %s level %u node ",
>   				   bch2_btree_id_str(b->c.btree_id), b->c.level);
>   			bch2_bkey_val_to_text(&buf, c, bkey_i_to_s_c(&b->key));

[PATCH] bcachefs: Convert comma to semicolon

[Chen Ni]

Replace comma between expressions with semicolons.

Using a ',' in place of a ';' can have unintended side effects.
Although that is not the case here, it is seems best to use ';'
unless ',' is intended.

Found by inspection.
No functional change intended.
Compile tested only.

Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
 fs/bcachefs/disk_groups.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/bcachefs/disk_groups.c b/fs/bcachefs/disk_groups.c
index c20ecf5e5381..5b03e93630b8 100644
--- a/fs/bcachefs/disk_groups.c
+++ b/fs/bcachefs/disk_groups.c
@@ -413,7 +413,7 @@ void bch2_disk_path_to_text(struct printbuf *out, struct bch_fs *c, unsigned v)
 {
 	out->atomic++;
 	rcu_read_lock();
-	__bch2_disk_path_to_text(out, rcu_dereference(c->disk_groups), v),
+	__bch2_disk_path_to_text(out, rcu_dereference(c->disk_groups), v);
 	rcu_read_unlock();
 	--out->atomic;
 }
-- 
2.25.1

[PATCH] bcachefs: Convert comma to semicolon

[Chen Ni]

Replace comma between expressions with semicolons.

Using a ',' in place of a ';' can have unintended side effects.
Although that is not the case here, it is seems best to use ';'
unless ',' is intended.

Found by inspection.
No functional change intended.
Compile tested only.

Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
 fs/bcachefs/btree_node_scan.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/bcachefs/btree_node_scan.c b/fs/bcachefs/btree_node_scan.c
index 4b7b5ca74ba1..ca289d60aebe 100644
--- a/fs/bcachefs/btree_node_scan.c
+++ b/fs/bcachefs/btree_node_scan.c
@@ -193,7 +193,7 @@ static void try_read_btree_node(struct find_btree_nodes *f, struct bch_dev *ca,
 		 * any bset; read_done sorts down to a single set and picks the
 		 * max journal_seq
 		 */
-		n.journal_seq		= le64_to_cpu(bn->keys.journal_seq),
+		n.journal_seq		= le64_to_cpu(bn->keys.journal_seq);
 		n.sectors_written	= b->written;
 
 		guard(mutex)(&f->lock);
-- 
2.25.1