* [PATCH] bcachefs: Add missing else statement
@ 2025-08-04 17:01 Alan Huang
2025-08-04 17:11 ` Kent Overstreet
0 siblings, 1 reply; 2+ messages in thread
From: Alan Huang @ 2025-08-04 17:01 UTC (permalink / raw)
To: kent.overstreet; +Cc: linux-bcachefs, Alan Huang
The if condition was broken, ret was always assigned to BCH_ERR_fsck_delete_bkey
Signed-off-by: Alan Huang <mmpgouride@gmail.com>
---
fs/bcachefs/error.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/fs/bcachefs/error.h b/fs/bcachefs/error.h
index 0c3c3a24fc6f..213814787dd6 100644
--- a/fs/bcachefs/error.h
+++ b/fs/bcachefs/error.h
@@ -173,7 +173,8 @@ do { \
if (!bch2_err_matches(_ret, BCH_ERR_fsck_fix) && \
!bch2_err_matches(_ret, BCH_ERR_fsck_ignore)) \
ret = _ret; \
- ret = bch_err_throw(c, fsck_delete_bkey); \
+ else \
+ ret = bch_err_throw(c, fsck_delete_bkey); \
goto fsck_err; \
} while (0)
--
2.49.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] bcachefs: Add missing else statement
2025-08-04 17:01 [PATCH] bcachefs: Add missing else statement Alan Huang
@ 2025-08-04 17:11 ` Kent Overstreet
0 siblings, 0 replies; 2+ messages in thread
From: Kent Overstreet @ 2025-08-04 17:11 UTC (permalink / raw)
To: Alan Huang; +Cc: linux-bcachefs
On Tue, Aug 05, 2025 at 01:01:27AM +0800, Alan Huang wrote:
> The if condition was broken, ret was always assigned to BCH_ERR_fsck_delete_bkey
>
> Signed-off-by: Alan Huang <mmpgouride@gmail.com>
Applied
> ---
> fs/bcachefs/error.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/fs/bcachefs/error.h b/fs/bcachefs/error.h
> index 0c3c3a24fc6f..213814787dd6 100644
> --- a/fs/bcachefs/error.h
> +++ b/fs/bcachefs/error.h
> @@ -173,7 +173,8 @@ do { \
> if (!bch2_err_matches(_ret, BCH_ERR_fsck_fix) && \
> !bch2_err_matches(_ret, BCH_ERR_fsck_ignore)) \
> ret = _ret; \
> - ret = bch_err_throw(c, fsck_delete_bkey); \
> + else \
> + ret = bch_err_throw(c, fsck_delete_bkey); \
> goto fsck_err; \
> } while (0)
>
> --
> 2.49.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-08-04 17:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-04 17:01 [PATCH] bcachefs: Add missing else statement Alan Huang
2025-08-04 17:11 ` Kent Overstreet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox