From: "John Stoffel" <john@stoffel.org>
To: Alan Huang <mmpgouride@gmail.com>
Cc: kent.overstreet@linux.dev, linux-bcachefs@vger.kernel.org
Subject: Re: [PATCH] bcachefs: Increase blacklist range
Date: Mon, 17 Mar 2025 16:58:26 -0400 [thread overview]
Message-ID: <26584.36082.936426.143774@quad.stoffel.home> (raw)
In-Reply-To: <20250315073942.1909895-1-mmpgouride@gmail.com>
>>>>> "Alan" == Alan Huang <mmpgouride@gmail.com> writes:
> Now there are 16 journal buffers, 8 is too small to be enough.
> Signed-off-by: Alan Huang <mmpgouride@gmail.com>
> ---
> fs/bcachefs/recovery.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/fs/bcachefs/recovery.c b/fs/bcachefs/recovery.c
> index 71c786cdb192..a6e26733854d 100644
> --- a/fs/bcachefs/recovery.c
> +++ b/fs/bcachefs/recovery.c
> @@ -899,7 +899,7 @@ int bch2_fs_recovery(struct bch_fs *c)
> * journal sequence numbers:
> */
> if (!c->sb.clean)
> - journal_seq += 8;
> + journal_seq += JOURNAL_BUF_NR * 4;
Instead of magic numbers, could you put in a define with an
explanation of how you arrived at this number? Just to document the
assumptions better?
John
next prev parent reply other threads:[~2025-03-17 20:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-15 7:39 [PATCH] bcachefs: Increase blacklist range Alan Huang
2025-03-15 21:49 ` Kent Overstreet
2025-03-17 20:58 ` John Stoffel [this message]
2025-03-18 0:33 ` Kent Overstreet
2025-03-18 14:26 ` John Stoffel
2025-03-18 14:57 ` Kent Overstreet
2025-03-18 15:19 ` Alan Huang
2025-03-18 16:46 ` Kent Overstreet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26584.36082.936426.143774@quad.stoffel.home \
--to=john@stoffel.org \
--cc=kent.overstreet@linux.dev \
--cc=linux-bcachefs@vger.kernel.org \
--cc=mmpgouride@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox