From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f42.google.com (mail-ot1-f42.google.com [209.85.210.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A612E20125F for ; Wed, 27 Nov 2024 21:52:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732744357; cv=none; b=Q5mkFZSO1LO3cDCQzDbCsmzYI20sW/P+25GqqL8l4x0W8q5TkL/AJO5o1HCwBLzqhWDHRMkPlXHr8y+5X2IqyoMO05jNbF9jRwjJY4fj8hy23PVvkXtaHx6rG6sn7K9kl0V0tRCFkzSlOk/KdUOwUjNiPO1aVjc9N6pQdP0uGxY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732744357; c=relaxed/simple; bh=EM/4mHDM8IGSubI+o454Y3goHzwpuRKt6oB8kvXn198=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=o/D2ZfluP6bviI96wf8oEZsZ63D6Dmd3cRkIdb79pFKdxRSELUSmd0R1k5rZRCdOTMx549lnD9KN86UZg+kIpIGRBPmApAyUWVqLRgcqmPGfSmjK7sNxZRSvj+b/N6ZQhZRDunrcNyAtQimBu1BE2DlSk0t8+1hFw3E7nwM+3kI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=tRiK3LIX; arc=none smtp.client-ip=209.85.210.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="tRiK3LIX" Received: by mail-ot1-f42.google.com with SMTP id 46e09a7af769-71d4d3738cdso77722a34.3 for ; Wed, 27 Nov 2024 13:52:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1732744354; x=1733349154; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=zXBXv71yrwh/W96nQYPOr57MuN6FAQnmq0hsvo2YPvo=; b=tRiK3LIXTo0fmYGB3vWLZuvv7HKNorc1ebP37vtXvhVNvgaE2ob4crk4+4Q0rmC7lV gbVg+LRPbozSEjKIojsSGsjOXbIi4oaGvKkt0I6mvVX/WrkpwHrSYX3w/Bs7EE5aOjbX gFN/ltu+UuMCkCohLjyOvgQzXygvpuq8n0yKa0HkfDY4+uhQmiG5PQn5kARzJiJJrWBu oLDnphOobBxuhcunhiiWp95EdoOmfl+/mulL+1onWPeywb1FOKhJK8wQCO7mGEhHbbkL sMudeblimG027931KWr+TN32eWPB6m/T6Hsdd4/hDaDi/LZhpzLloaXaioDnJ4LQldgQ diyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732744354; x=1733349154; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zXBXv71yrwh/W96nQYPOr57MuN6FAQnmq0hsvo2YPvo=; b=inCui7JDX+1f+CQareDx+4q0srm1WiwKDh3qi24aHFPIfrm3PTHf+Or/cZcuFQU1RO 6cDgAhSJIWNrYwWWIeszDv+euFlLsA0hX82sDxd8cCq+BKXI5dPOsTY5sTkAUCwA5G9b J5t6d32iQXe9bqKIxlY8EraRJdPwfZf6scniIZHe1+GH3GnAxDNcScZCVVIGuit2nGT1 XdnKzfi5kT+rwyihy3utGeNnbCbQJhcA2qBRaDhv/yip8IRR+uNreC+P0ZnBV/98vygW 8pDSdmcM4e0ke1yOOUQUlERP9qm5yoMEqLXisvOIy4fKBayOgGjiMn+Vhc37QcnqQMnf SrAg== X-Forwarded-Encrypted: i=1; AJvYcCW+NmRQ0VFGOECodsoRvSWjqwTsHHA3YxljqA7wFBtiJIlSoNBRgt0NFmdXjoVKRYlkfe+wu4jqSzbi4WMiPA==@vger.kernel.org X-Gm-Message-State: AOJu0YyY75NhkCVlF0tquGQDR9K3EVTYHRX6oEif2VJO2MwObyLsmxVP V35PTAHG3biZHkL3x6vHT7HliPrdEHlg2thmA9sUIAFS1PXPE8njutGjP6R9G3Y= X-Gm-Gg: ASbGncuSTt3E6AmhUL4HUqdGCkqn/UqOtPQLsDpxot4uFfWMKSwmVsBd7oj/P/uxfYx cCMrRq9+S4dgiQldNc+yjjYqELR8CjoDWr2xTHhFdgaSRlvvsJfemPHNhnZh0wUOB2FEj+pvxoD BOOiwEqpyKJ6DU7cPc8xQFeIsbX84vfnCQseKP0SUZP+vKS2RuYvjy5+UmDxZkBu5aYEdSrIQ/E y4pbY4W3bRVnQMIsxbR62xQgwtpsfFVbCobAU7wUkj8kQ== X-Google-Smtp-Source: AGHT+IGeeLFCPusmOIhw+35AOSNyBrWyt/GW4UJ4w87XtENHZrksBW3r4sJQ0Nqdv4tVolmCtBkvAw== X-Received: by 2002:a05:6830:6996:b0:718:9c7c:2b33 with SMTP id 46e09a7af769-71d65cf3b0dmr4424477a34.23.1732744353716; Wed, 27 Nov 2024 13:52:33 -0800 (PST) Received: from [192.168.1.116] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-5f21a366532sm19894eaf.12.2024.11.27.13.52.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Nov 2024 13:52:33 -0800 (PST) Message-ID: <4715a920-ae4b-41d4-97ae-0fb92b4fa024@kernel.dk> Date: Wed, 27 Nov 2024 14:52:32 -0700 Precedence: bulk X-Mailing-List: linux-bcachefs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Jens Axboe Subject: Re: bcachefs: suspicious mm pointer in struct dio_write To: Jann Horn Cc: Kent Overstreet , linux-bcachefs@vger.kernel.org, kernel list , Pavel Begunkov , io-uring References: <69510752-d6f9-4cf1-b93d-dcd249d911ef@kernel.dk> <3ajlmjyqz6aregccuysq3juhxrxy5zzgdrufrfwjfab55cv2aa@oneydwsnucnj> <4f7e45b6-c237-404a-a4c0-4929fa3f1c4b@kernel.dk> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit > On Wed, Nov 27, 2024 at 10:16?PM Jens Axboe wrote: > > On 11/27/24 2:08 PM, Kent Overstreet wrote: > > > On Wed, Nov 27, 2024 at 09:44:21PM +0100, Jann Horn wrote: > > >> On Wed, Nov 27, 2024 at 9:25?PM Kent Overstreet > > >> wrote: > > >>> On Wed, Nov 27, 2024 at 11:09:14AM -0700, Jens Axboe wrote: > > >>>> On 11/27/24 9:57 AM, Jann Horn wrote: > > >>>>> Hi! > > >>>>> > > >>>>> In fs/bcachefs/fs-io-direct.c, "struct dio_write" contains a pointer > > >>>>> to an mm_struct. This pointer is grabbed in bch2_direct_write() > > >>>>> (without any kind of refcount increment), and used in > > >>>>> bch2_dio_write_continue() for kthread_use_mm()/kthread_unuse_mm() > > >>>>> which are used to enable userspace memory access from kthread context. > > >>>>> I believe kthread_use_mm()/kthread_unuse_mm() require that the caller > > >>>>> guarantees that the MM hasn't gone through exit_mmap() yet (normally > > >>>>> by holding an mmget() reference). > > >>>>> > > >>>>> If we reach this codepath via io_uring, do we have a guarantee that > > >>>>> the mm_struct that called bch2_direct_write() is still alive and > > >>>>> hasn't yet gone through exit_mmap() when it is accessed from > > >>>>> bch2_dio_write_continue()? > > >>>>> > > >>>>> I don't know the async direct I/O codepath particularly well, so I > > >>>>> cc'ed the uring maintainers, who probably know this better than me. > > >>>> > > >>>> I _think_ this is fine as-is, even if it does look dubious and bcachefs > > >>>> arguably should grab an mm ref for this just for safety to avoid future > > >>>> problems. The reason is that bcachefs doesn't set FMODE_NOWAIT, which > > >>>> means that on the io_uring side it cannot do non-blocking issue of > > >>>> requests. This is slower as it always punts to an io-wq thread, which > > >>>> shares the same mm. Hence if the request is alive, there's always a > > >>>> thread with the same mm alive as well. > > >>>> > > >>>> Now if FMODE_NOWAIT was set, then the original task could exit. I'd need > > >>>> to dig a bit deeper to verify that would always be safe and there's not > > >>>> a of time today with a few days off in the US looming, so I'll defer > > >>>> that to next week. It certainly would be fine with an mm ref grabbed. > > >>> > > >>> Wouldn't delivery of completions be tied to an address space (not a > > >>> process) like it is for aio? > > >> > > >> An io_uring instance is primarily exposed to userspace as a file > > >> descriptor, so AFAIK it is possible for the io_uring instance to live > > >> beyond when the last mmput() happens. io_uring initially only holds an > > >> mmgrab() reference on the MM (a comment above that explains: "This is > > >> just grabbed for accounting purposes"), which I think is not enough to > > >> make it stable enough for kthread_use_mm(); I think in io_uring, only > > >> the worker threads actually keep the MM fully alive (and AFAIK the > > >> uring worker threads can exit before the uring instance itself is torn > > >> down). > > >> > > >> To receive io_uring completions, there are multiple ways, but they > > >> don't use a pointer from the io_uring instance to the MM to access > > >> userspace memory. Instead, you can have a VMA that points to the > > >> io_uring instance, created by calling mmap() on the io_uring fd; or > > >> alternatively, with IORING_SETUP_NO_MMAP, you can have io_uring grab > > >> references to userspace-provided pages. > > >> > > >> On top of that, I think it might currently be possible to use the > > >> io_uring file descriptor from another task to submit work. (That would > > >> probably be fairly nonsensical, but I think the kernel does not > > >> currently prevent it.) > > > > > > Ok, that's a wrinkle. > > > > I'd argue the fact that you are using an mm from a different process > > without grabbing a reference is the wrinkle. I just don't think it's a > > problem right now, but it could be... aio is tied to the mm because of > > how it does completions, potentially, and hence needs this exit_aio() > > hack because of that. aio also doesn't care, because it doesn't care > > about blocking - it'll happily block during issue. > > > > > Jens, is it really FMODE_NOWAIT that controls whether we can hit this? A > > > very cursory glance leads me to suspect "no", it seems like this is a > > > bug if io_uring is allowed on bcachefs at all. > > > > I just looked at bcachefs dio writes, which look to be the only case of > > this. And yes, for writes, if FMODE_NOWAIT isn't set, then io-wq is > > always involved for the IO. > > I guess it could be an issue if the iocb can outlive the io-wq thread? > Like, a userspace task creates a uring instance and starts a write; > the write will be punted to a uring worker because of missing > FMODE_NOWAIT; then the uring worker enters io_write() and starts a > write on a kiocb. Can this write initiated from the worker be async? > And could the uring worker exit (for example, because the userspace > task exited) while the kiocb is still in flight? No, any write (or read, whatever) from an io-wq worker is always blocking / sync. That's the main reason for them existing, to be able to do blocking issue. And that's what they always do. -- Jens Axboe