[syzbot] [bcachefs?] WARNING in bch2_fs_release

[syzbot] [bcachefs?] WARNING in bch2_fs_release

[syzbot]

Hello,

syzbot found the following issue on:

HEAD commit:    5f5673607153 Merge branch 'for-next/core' into for-kernelci
git tree:       git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci
console output: https://syzkaller.appspot.com/x/log.txt?x=108f7500580000
kernel config:  https://syzkaller.appspot.com/x/.config?x=dedbcb1ff4387972
dashboard link: https://syzkaller.appspot.com/bug?extid=08d08d52c3a09bfc70f7
compiler:       Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
userspace arch: arm64
syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=148f7500580000

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/40172aed5414/disk-5f567360.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/58372f305e9d/vmlinux-5f567360.xz
kernel image: https://storage.googleapis.com/syzbot-assets/d2aae6fa798f/Image-5f567360.gz.xz
mounted in repro: https://storage.googleapis.com/syzbot-assets/019ec069588b/mount_0.gz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+08d08d52c3a09bfc70f7@syzkaller.appspotmail.com

------------[ cut here ]------------
online_reserved not 0 at shutdown: 4
WARNING: CPU: 1 PID: 7017 at fs/bcachefs/super.c:568 __bch2_fs_free fs/bcachefs/super.c:568 [inline]
WARNING: CPU: 1 PID: 7017 at fs/bcachefs/super.c:568 bch2_fs_release+0x6c4/0x720 fs/bcachefs/super.c:608
Modules linked in:
CPU: 1 UID: 0 PID: 7017 Comm: syz.4.63 Not tainted 6.11.0-rc7-syzkaller-g5f5673607153 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 08/06/2024
pstate: 60400005 (nZCv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--)
pc : __bch2_fs_free fs/bcachefs/super.c:568 [inline]
pc : bch2_fs_release+0x6c4/0x720 fs/bcachefs/super.c:608
lr : __bch2_fs_free fs/bcachefs/super.c:568 [inline]
lr : bch2_fs_release+0x6c4/0x720 fs/bcachefs/super.c:608
sp : ffff80009b667500
x29: ffff80009b667520 x28: 00007dfe9b5f3270 x27: ffffffffffffffff
x26: dfff800000000000 x25: ffff0000f5f80000 x24: 0000000000000008
x23: 0000000000000004 x22: 1fffe0001ebf093e x21: ffff0000f5fca1e8
x20: 0000000000000008 x19: ffff0000f5f80068 x18: 1fffe000366d79ee
x17: ffff80008f56d000 x16: ffff800080347214 x15: 0000000000000001
x14: 1fffe00019a65a00 x13: 0000000000000000 x12: 0000000000000000
x11: ffff600019a65a01 x10: 1fffe00019a65a00 x9 : 8734dde5ec21bf00
x8 : 8734dde5ec21bf00 x7 : ffff8000802b7e24 x6 : 0000000000000000
x5 : 0000000000000001 x4 : 0000000000000001 x3 : ffff8000802aa83c
x2 : 0000000000000001 x1 : 0000000000000004 x0 : 0000000000000001
Call trace:
 __bch2_fs_free fs/bcachefs/super.c:568 [inline]
 bch2_fs_release+0x6c4/0x720 fs/bcachefs/super.c:608
 kobject_cleanup lib/kobject.c:689 [inline]
 kobject_release lib/kobject.c:720 [inline]
 kref_put include/linux/kref.h:65 [inline]
 kobject_put+0x2a8/0x41c lib/kobject.c:737
 bch2_fs_free+0x2c4/0x334 fs/bcachefs/super.c:672
 bch2_fs_stop+0x28/0x38 fs/bcachefs/super.c:678
 bch2_fs_get_tree+0xab0/0x1030 fs/bcachefs/fs.c:2041
 vfs_get_tree+0x90/0x28c fs/super.c:1800
 do_new_mount+0x278/0x900 fs/namespace.c:3472
 path_mount+0x590/0xe04 fs/namespace.c:3799
 do_mount fs/namespace.c:3812 [inline]
 __do_sys_mount fs/namespace.c:4020 [inline]
 __se_sys_mount fs/namespace.c:3997 [inline]
 __arm64_sys_mount+0x45c/0x5a8 fs/namespace.c:3997
 __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline]
 invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49
 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132
 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151
 el0_svc+0x54/0x168 arch/arm64/kernel/entry-common.c:712
 el0t_64_sync_handler+0x84/0xfc arch/arm64/kernel/entry-common.c:730
 el0t_64_sync+0x190/0x194 arch/arm64/kernel/entry.S:598
irq event stamp: 90582
hardirqs last  enabled at (90581): [<ffff8000802b7ec4>] raw_spin_rq_unlock_irq kernel/sched/sched.h:1427 [inline]
hardirqs last  enabled at (90581): [<ffff8000802b7ec4>] finish_lock_switch+0xbc/0x1e4 kernel/sched/core.c:4942
hardirqs last disabled at (90582): [<ffff80008b3363f4>] el1_dbg+0x24/0x80 arch/arm64/kernel/entry-common.c:470
softirqs last  enabled at (90568): [<ffff8000801f8e88>] softirq_handle_end kernel/softirq.c:400 [inline]
softirqs last  enabled at (90568): [<ffff8000801f8e88>] handle_softirqs+0xa3c/0xbfc kernel/softirq.c:582
softirqs last disabled at (90505): [<ffff800080020de8>] __do_softirq+0x14/0x20 kernel/softirq.c:588
---[ end trace 0000000000000000 ]---
bcachefs: bch2_fs_get_tree() error: fsck_errors_not_fixed
syz.4.63 (7017): drop_caches: 2
syz.4.63 (7017): drop_caches: 2


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzkaller@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

If the report is already addressed, let syzbot know by replying with:
#syz fix: exact-commit-title

If you want syzbot to run the reproducer, reply with:
#syz test: git://repo/address.git branch-or-commit-hash
If you attach or paste a git patch, syzbot will apply it before testing.

If you want to overwrite report's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)

If the report is a duplicate of another one, reply with:
#syz dup: exact-subject-of-another-report

If you want to undo deduplication, reply with:
#syz undup

Re: [syzbot] [bcachefs?] WARNING in bch2_fs_release

[syzbot]

syzbot has found a reproducer for the following issue on:

HEAD commit:    8f6629c004b1 kbuild: Move -Wenum-enum-conversion to W=2
git tree:       upstream
console+strace: https://syzkaller.appspot.com/x/log.txt?x=12b102a4580000
kernel config:  https://syzkaller.appspot.com/x/.config?x=147b7d49d83b8036
dashboard link: https://syzkaller.appspot.com/bug?extid=08d08d52c3a09bfc70f7
compiler:       Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=1312cbdf980000
C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=129411b0580000

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/f60addb0f276/disk-8f6629c0.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/59d0658fa6fd/vmlinux-8f6629c0.xz
kernel image: https://storage.googleapis.com/syzbot-assets/25afa4128fc2/bzImage-8f6629c0.xz
mounted in repro: https://storage.googleapis.com/syzbot-assets/574abc7822e2/mount_0.gz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+08d08d52c3a09bfc70f7@syzkaller.appspotmail.com

bcachefs (loop0): shutting down
bcachefs (loop0): shutdown complete
------------[ cut here ]------------
online_reserved not 0 at shutdown: 1792
WARNING: CPU: 0 PID: 5820 at fs/bcachefs/super.c:585 __bch2_fs_free fs/bcachefs/super.c:585 [inline]
WARNING: CPU: 0 PID: 5820 at fs/bcachefs/super.c:585 bch2_fs_release+0x744/0x7b0 fs/bcachefs/super.c:624
Modules linked in:
CPU: 0 UID: 0 PID: 5820 Comm: syz-executor117 Not tainted 6.14.0-rc1-syzkaller-00187-g8f6629c004b1 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 12/27/2024
RIP: 0010:__bch2_fs_free fs/bcachefs/super.c:585 [inline]
RIP: 0010:bch2_fs_release+0x744/0x7b0 fs/bcachefs/super.c:624
Code: 41 5e 41 5f 5d e9 2c 67 33 fd e8 37 85 49 fd e9 06 fd ff ff e8 2d 85 49 fd 90 48 c7 c7 a0 6a 55 8c 4c 89 ee e8 fd 2f 0a fd 90 <0f> 0b 90 90 e9 13 fd ff ff 44 89 f1 80 e1 07 38 c1 0f 8c 18 fb ff
RSP: 0018:ffffc90003e2fb88 EFLAGS: 00010246
RAX: c22db852ba485a00 RBX: ffff888077104a10 RCX: ffff88807de41e00
RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000000
RBP: 1ffff1100ee20942 R08: ffffffff81800b32 R09: 1ffff110170c519a
R10: dffffc0000000000 R11: ffffed10170c519b R12: 00000000fffffff8
R13: 0000000000000700 R14: dffffc0000000000 R15: 0000607f47622c00
FS:  000055555c502380(0000) GS:ffff8880b8600000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007fff51ad82bc CR3: 00000000781b8000 CR4: 00000000003526f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
 <TASK>
 kobject_cleanup lib/kobject.c:689 [inline]
 kobject_release lib/kobject.c:720 [inline]
 kref_put include/linux/kref.h:65 [inline]
 kobject_put+0x22f/0x480 lib/kobject.c:737
 deactivate_locked_super+0xc4/0x130 fs/super.c:473
 cleanup_mnt+0x41f/0x4b0 fs/namespace.c:1413
 task_work_run+0x24f/0x310 kernel/task_work.c:227
 ptrace_notify+0x2d2/0x380 kernel/signal.c:2522
 ptrace_report_syscall include/linux/ptrace.h:415 [inline]
 ptrace_report_syscall_exit include/linux/ptrace.h:477 [inline]
 syscall_exit_work+0xc7/0x1d0 kernel/entry/common.c:173
 syscall_exit_to_user_mode_prepare kernel/entry/common.c:200 [inline]
 __syscall_exit_to_user_mode_work kernel/entry/common.c:205 [inline]
 syscall_exit_to_user_mode+0x24a/0x340 kernel/entry/common.c:218
 do_syscall_64+0x100/0x230 arch/x86/entry/common.c:89
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f8aac0ec447
Code: 07 00 48 83 c4 08 5b 5d c3 66 2e 0f 1f 84 00 00 00 00 00 c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 b8 a6 00 00 00 0f 05 <48> 3d 00 f0 ff ff 77 01 c3 48 c7 c2 b8 ff ff ff f7 d8 64 89 02 b8
RSP: 002b:00007fff51ad82a8 EFLAGS: 00000202 ORIG_RAX: 00000000000000a6
RAX: 0000000000000000 RBX: 0000000000000000 RCX: 00007f8aac0ec447
RDX: 0000000000000000 RSI: 0000000000000009 RDI: 00007fff51ad8360
RBP: 00007fff51ad8360 R08: 0000000000000000 R09: 0000000000000000
R10: 00000000ffffffff R11: 0000000000000202 R12: 00007fff51ad93d0
R13: 000055555c5036c0 R14: 0000000000000001 R15: 431bde82d7b634db
 </TASK>


---
If you want syzbot to run the reproducer, reply with:
#syz test: git://repo/address.git branch-or-commit-hash
If you attach or paste a git patch, syzbot will apply it before testing.

Re: [syzbot] [bcachefs?] WARNING in bch2_fs_release

[syzbot]

syzbot has bisected this issue to:

commit 8b22abb4c84058e9533d71a4814e54316ba2621f
Author: Kent Overstreet <kent.overstreet@linux.dev>
Date:   Sat Oct 12 02:53:09 2024 +0000

    bcachefs: -o norecovery now bails out of recovery earlier

bisection log:  https://syzkaller.appspot.com/x/bisect.txt?x=121ddb18580000
start commit:   8f6629c004b1 kbuild: Move -Wenum-enum-conversion to W=2
git tree:       upstream
final oops:     https://syzkaller.appspot.com/x/report.txt?x=111ddb18580000
console output: https://syzkaller.appspot.com/x/log.txt?x=161ddb18580000
kernel config:  https://syzkaller.appspot.com/x/.config?x=147b7d49d83b8036
dashboard link: https://syzkaller.appspot.com/bug?extid=08d08d52c3a09bfc70f7
syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=1312cbdf980000
C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=129411b0580000

Reported-by: syzbot+08d08d52c3a09bfc70f7@syzkaller.appspotmail.com
Fixes: 8b22abb4c840 ("bcachefs: -o norecovery now bails out of recovery earlier")

For information about bisection process see: https://goo.gl/tpsmEJ#bisection

Re: [syzbot] [bcachefs?] WARNING in bch2_fs_release

[syzbot]

syzbot suspects this issue was fixed by commit:

commit 04e90891be26a240e41d51d1770de56e810fda5e
Author: Kent Overstreet <kent.overstreet@linux.dev>
Date:   Thu Mar 20 15:41:07 2025 +0000

    bcachefs: Run bch2_check_dirent_target() at lookup time

bisection log:  https://syzkaller.appspot.com/x/bisect.txt?x=115ed8f4580000
start commit:   a7f2e10ecd8f Merge tag 'hwmon-fixes-for-v6.14-rc8/6.14' of..
git tree:       upstream
kernel config:  https://syzkaller.appspot.com/x/.config?x=620facf12ff15d10
dashboard link: https://syzkaller.appspot.com/bug?extid=08d08d52c3a09bfc70f7
syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=10d11e98580000
C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=114b1004580000

If the result looks correct, please mark the issue as fixed by replying with:

#syz fix: bcachefs: Run bch2_check_dirent_target() at lookup time

For information about bisection process see: https://goo.gl/tpsmEJ#bisection