From: Brian Foster <bfoster@redhat.com>
To: Colin Ian King <colin.i.king@gmail.com>
Cc: Kent Overstreet <kent.overstreet@linux.dev>,
linux-bcachefs@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/5][next] bcachefs: clean up some redundant assignments
Date: Tue, 12 Sep 2023 09:52:26 -0400 [thread overview]
Message-ID: <ZQBtGi+iLEglpt8x@bfoster> (raw)
In-Reply-To: <20230912123744.3929609-1-colin.i.king@gmail.com>
On Tue, Sep 12, 2023 at 01:37:39PM +0100, Colin Ian King wrote:
> Clean up some redundant assignments and variables based on warnings
> found by clang scan build static analysis.
>
These all look good to me. For the series:
Reviewed-by: Brian Foster <bfoster@redhat.com>
> Colin Ian King (5):
> bcachefs: remove redundant initialization of pointer d
> bcachefs: remove redundant initialization of pointer dst
> bcachefs: remove redundant initializations of variables start_offset
> and end_offset
> bcachefs: remove duplicated assignment to variable offset_into_extent
> bcachefs: remove redundant pointer q
>
> fs/bcachefs/btree_update_interior.c | 2 +-
> fs/bcachefs/buckets.c | 2 +-
> fs/bcachefs/disk_groups.c | 3 +--
> fs/bcachefs/fs-io.c | 4 ++--
> fs/bcachefs/io.c | 1 -
> fs/bcachefs/quota.c | 3 ---
> 6 files changed, 5 insertions(+), 10 deletions(-)
>
> --
> 2.39.2
>
next prev parent reply other threads:[~2023-09-12 13:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-12 12:37 [PATCH 0/5][next] bcachefs: clean up some redundant assignments Colin Ian King
2023-09-12 12:37 ` [PATCH 1/5][next] bcachefs: remove redundant initialization of pointer d Colin Ian King
2023-09-12 12:37 ` [PATCH 2/5][next] bcachefs: remove redundant initialization of pointer dst Colin Ian King
2023-09-12 13:52 ` Brian Foster
2023-09-12 12:37 ` [PATCH 3/5][next] bcachefs: remove redundant initializations of variables start_offset and end_offset Colin Ian King
2023-09-12 12:37 ` [PATCH 4/5][next] bcachefs: remove duplicated assignment to variable offset_into_extent Colin Ian King
2023-09-12 12:37 ` [PATCH 5/5][next] bcachefs: remove redundant pointer q Colin Ian King
2023-09-12 13:52 ` Brian Foster [this message]
2023-09-12 16:27 ` [PATCH 0/5][next] bcachefs: clean up some redundant assignments Kent Overstreet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZQBtGi+iLEglpt8x@bfoster \
--to=bfoster@redhat.com \
--cc=colin.i.king@gmail.com \
--cc=kent.overstreet@linux.dev \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-bcachefs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox