From: Brian Foster <bfoster@redhat.com>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: Kent Overstreet <kent.overstreet@linux.dev>,
linux-bcachefs@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] bcachefs: fix error checking in bch2_fs_alloc()
Date: Thu, 14 Sep 2023 07:50:25 -0400 [thread overview]
Message-ID: <ZQLzgaYY0pWX7y07@bfoster> (raw)
In-Reply-To: <a0032f97-333a-41ec-97b0-62f0b6135d54@moroto.mountain>
On Thu, Sep 14, 2023 at 12:47:44PM +0300, Dan Carpenter wrote:
> There is a typo here where it uses ";" instead of "?:". The result is
> that bch2_fs_fs_io_direct_init() is called unconditionally and the errors
> from it are not checked.
>
> Fixes: 0060c68159fc ("bcachefs: Split up fs-io.[ch]")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
Reviewed-by: Brian Foster <bfoster@redhat.com>
> fs/bcachefs/super.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/bcachefs/super.c b/fs/bcachefs/super.c
> index 29cd71445a94..4831010c0dfd 100644
> --- a/fs/bcachefs/super.c
> +++ b/fs/bcachefs/super.c
> @@ -856,7 +856,7 @@ static struct bch_fs *bch2_fs_alloc(struct bch_sb *sb, struct bch_opts opts)
> bch2_fs_compress_init(c) ?:
> bch2_fs_ec_init(c) ?:
> bch2_fs_fsio_init(c) ?:
> - bch2_fs_fs_io_buffered_init(c);
> + bch2_fs_fs_io_buffered_init(c) ?:
> bch2_fs_fs_io_direct_init(c);
> if (ret)
> goto err;
> --
> 2.39.2
>
next prev parent reply other threads:[~2023-09-14 11:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-14 9:47 [PATCH] bcachefs: fix error checking in bch2_fs_alloc() Dan Carpenter
2023-09-14 11:50 ` Brian Foster [this message]
2023-09-14 19:58 ` Kent Overstreet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZQLzgaYY0pWX7y07@bfoster \
--to=bfoster@redhat.com \
--cc=dan.carpenter@linaro.org \
--cc=kent.overstreet@linux.dev \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-bcachefs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox