From: Richard Davies <richard@arachsys.com>
To: Kent Overstreet <kent.overstreet@linux.dev>
Cc: linux-bcachefs@vger.kernel.org
Subject: Re: [PATCH] bcachefs: Remove obsolete comment about zstd
Date: Sun, 3 Dec 2023 14:16:22 +0000 [thread overview]
Message-ID: <ZWyNtrC69FB6ndcL@delta.arachsys.com> (raw)
In-Reply-To: <ZWxtuIL8nbIHQ3bw@delta.arachsys.com>
Sorry, broken whitespace context in this version.
I've sent a v2 with git send-email, not my mail client...
Richard Davies wrote:
> Remove obsolete comment about zstd, since approach changed during
> development of commit bbc3a46065d08f9ab3412b1f26bbfa778c444833
>
> Signed-off-by: Richard Davies <richard@arachsys.com>
> ---
> fs/bcachefs/compress.c | 4 ----
> 1 files changed, 0 insertions(+), 4 deletions(-)
>
> diff --git a/fs/bcachefs/compress.c b/fs/bcachefs/compress.c
> index 51af8ea..33df8cf 100644
> --- a/fs/bcachefs/compress.c
> +++ b/fs/bcachefs/compress.c
> @@ -572,10 +572,6 @@ static int __bch2_fs_compress_init(struct bch_fs *c, u64 features)
> ZSTD_parameters params = zstd_get_params(zstd_max_clevel(),
> c->opts.encoded_extent_max);
> - /*
> - * ZSTD is lying: if we allocate the size of the workspace it says it
> - * requires, it returns memory allocation errors
> - */
> c->zstd_workspace_size = zstd_cctx_workspace_bound(¶ms.cParams);
> struct {
> --
> 1.7.0.3
prev parent reply other threads:[~2023-12-03 14:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-03 11:59 [PATCH] bcachefs: Remove obsolete comment about zstd Richard Davies
2023-12-03 14:16 ` Richard Davies [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZWyNtrC69FB6ndcL@delta.arachsys.com \
--to=richard@arachsys.com \
--cc=kent.overstreet@linux.dev \
--cc=linux-bcachefs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox