From: Brian Foster <bfoster@redhat.com>
To: Kent Overstreet <kent.overstreet@linux.dev>
Cc: Kevin Hao <haokexin@gmail.com>, linux-bcachefs@vger.kernel.org
Subject: Re: [PATCH] bcachefs: Remove unnecessary kthread_should_stop()
Date: Thu, 4 Jan 2024 06:49:40 -0500 [thread overview]
Message-ID: <ZZabVJRLBHTTcP2u@bfoster> (raw)
In-Reply-To: <20231219205538.5mcxzxnwt5djptjl@moria.home.lan>
On Tue, Dec 19, 2023 at 03:55:38PM -0500, Kent Overstreet wrote:
> On Tue, Dec 19, 2023 at 08:01:59AM -0500, Brian Foster wrote:
> > On Sat, Dec 16, 2023 at 09:51:40AM +0800, Kevin Hao wrote:
> > > In the macro kthread_wait_freezable(), there is already a check for
> > > kthread_should_stop(), so there is no need to pass kthread_should_stop()
> > > as a parameter to kthread_wait_freezable().
> > >
> > > Signed-off-by: Kevin Hao <haokexin@gmail.com>
> > > ---
> >
> > Looks right to me:
> >
> > Reviewed-by: Brian Foster <bfoster@redhat.com>
>
> It is technically correct, but recently the issues have been more with
> having too few kthread_should_stop() calls, not too many; I think I want
> to leave this for now, even though it's redundant it's more explicit.
>
What recent issues do you mean? ISTM this logic serves more as a placebo
than anything. Is there a more explicit issue to dig into?
Brian
prev parent reply other threads:[~2024-01-04 11:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-16 1:51 [PATCH] bcachefs: Remove unnecessary kthread_should_stop() Kevin Hao
2023-12-19 13:01 ` Brian Foster
2023-12-19 20:55 ` Kent Overstreet
2024-01-04 11:49 ` Brian Foster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZZabVJRLBHTTcP2u@bfoster \
--to=bfoster@redhat.com \
--cc=haokexin@gmail.com \
--cc=kent.overstreet@linux.dev \
--cc=linux-bcachefs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox