From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2391F219EB; Wed, 17 Jan 2024 16:01:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705507289; cv=none; b=FY5YDYM+a1XaoCy3TrjvrYSrzUdqfoDbKesbD6bz+EEtoEZ+hJGG15Gp0lvcDfnesPZ5Q5yPrr44Iepk40DkZG9KUk0TbisCTfn1Rt60BifEgQrEQFqmqP9wIo5SOuK2Voxoa3SjbvEwTq5M2eLY+B2jhTphqBjPGFg8VVSU1E8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705507289; c=relaxed/simple; bh=y0Z32RRY9+EpBV2HCKal46Ii0Wx2iH2dUNRhlc7J+Ug=; h=Received:DKIM-Signature:DKIM-Signature:DKIM-Signature: DKIM-Signature:Received:Received:Date:From:To:Cc:Subject: Message-ID:References:MIME-Version:Content-Type: Content-Disposition:In-Reply-To:X-Spamd-Result:X-Rspamd-Server: X-Spam-Score:X-Rspamd-Queue-Id:X-Spam-Level:X-Spam-Flag: X-Spamd-Bar; b=lbHtiFQnpQ+1QFSWoz5ZH/RojFr7ySh70q2EFTrmIvbhyuJdqrSjdzMjdxfXOlQp7k7DTRXcCF+tQ5UquZnsU5ZNtuRaQHfTPNH3w4zN0OlQfTyejMomlkO3IHJoTzKJI4MH26Pdm+jPSp2JJOPCyO3QveWmDrGmnM0hiYrddVI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz; spf=pass smtp.mailfrom=suse.cz; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b=3NA7NVG7; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b=FHUpMPMB; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b=CMOUoH71; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b=tiL1z4T1; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.cz Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b="3NA7NVG7"; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b="FHUpMPMB"; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b="CMOUoH71"; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b="tiL1z4T1" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id F18422201D; Wed, 17 Jan 2024 16:01:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1705507285; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=U6LQT3EAX10Xbl98egXwyCPpiHM9+YKBkqXHI5d0xKg=; b=3NA7NVG7SNjHjaIOqj+uNGy4H/WnpxHb4JlcHRCQyW2lEw0sspNx/Xu92BUmOaP/rNKCvG Cg/jVEPzSS7kW7M+IwtY05qoFwI6yPG7uON3f0CU31sV7oAQEEe5tmvzCDG8jVvM54h+uN 2KvC5bJGPSydFRTFYcf0jkHvzgCdIH8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1705507285; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=U6LQT3EAX10Xbl98egXwyCPpiHM9+YKBkqXHI5d0xKg=; b=FHUpMPMBMm4XsqDk1RmHn9RD3UuZ5kbqtP0mrzhkQGvqkkiJniNyN2V3AONBNgme5t5uBi pBE+chWFYO9asXDQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1705507284; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=U6LQT3EAX10Xbl98egXwyCPpiHM9+YKBkqXHI5d0xKg=; b=CMOUoH71QSm3v+LC7eNSdtfrGmJnHEU1oZJ3hBM9k+dQkFiVSPz5kBakFMJNGuKiZHajqm /epzAGuxKvn4W+GDzo6sJI9+DE24LhFpSGCFNpZ1oHg++4jJf12HKi6K31346fydlJ8mTK AUbA2SGnvQVAv8fYZb94Uv5vi9rxxVM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1705507284; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=U6LQT3EAX10Xbl98egXwyCPpiHM9+YKBkqXHI5d0xKg=; b=tiL1z4T1ifkxYncFZ+q7Z9T+MtxpRu9Vy3upIBlRcS7R9BAps+eX8u6RBQXW2EpaiuiWuf umriTPR9ih1KdECQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id DD1FE13751; Wed, 17 Jan 2024 16:01:24 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id fQn+NNT5p2WZJAAAD6G6ig (envelope-from ); Wed, 17 Jan 2024 16:01:24 +0000 Date: Wed, 17 Jan 2024 17:01:33 +0100 From: Cyril Hrubis To: Petr Vorel Cc: ltp@lists.linux.it, Li Wang , Jan Stancek , Xiao Yang , Yang Xu , Kent Overstreet , Brian Foster , linux-bcachefs@vger.kernel.org, fstests@vger.kernel.org Subject: Re: [PATCH 1/1] safe_macros: Fix bcachefs failure old kernel Message-ID: References: <20240111150553.1923767-1-pvorel@suse.cz> Precedence: bulk X-Mailing-List: linux-bcachefs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240111150553.1923767-1-pvorel@suse.cz> Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=CMOUoH71; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=tiL1z4T1 X-Spamd-Result: default: False [0.19 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; RCVD_COUNT_THREE(0.00)[3]; DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.cz:+]; MX_GOOD(-0.01)[]; RCPT_COUNT_SEVEN(0.00)[10]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.cz:dkim,suse.cz:email]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_NOT_FQDN(0.50)[]; RCVD_TLS_ALL(0.00)[] X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Spam-Score: 0.19 X-Rspamd-Queue-Id: F18422201D X-Spam-Level: X-Spam-Flag: NO X-Spamd-Bar: / Hi! > I'm sorry, although man bcachefs(8) mentions fusemount, I haven't > figured out how to mount filesystem. Am I missing something? > > Also, maybe for the start I would prefer to to test just kernel > functionality (no fuse). So this means that mount.bcasefs does exist, but the mount() fails? That sounds like something wasn't wired up properly. > Kind regards, > Petr > > lib/tst_supported_fs_types.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/lib/tst_supported_fs_types.c b/lib/tst_supported_fs_types.c > index 369836717..21765c370 100644 > --- a/lib/tst_supported_fs_types.c > +++ b/lib/tst_supported_fs_types.c > @@ -96,6 +96,11 @@ static enum tst_fs_impl has_kernel_support(const char *fs_type) > > SAFE_RMDIR(template); > > + if (!strcmp(fs_type, "bcachefs") && tst_kvercmp(6, 7, 0) < 0) { > + tst_res(TINFO, "bcachefs skipped on kernel < 6.7"); > + return TST_FS_UNSUPPORTED; > + } I would rather turn this into a FUSE specific blacklist without a kernel version, since bcachefs got into the kernel I do not think the fuse version would be useful for testhing at all, so what about: diff --git a/lib/tst_supported_fs_types.c b/lib/tst_supported_fs_types.c index 369836717..4110c826e 100644 --- a/lib/tst_supported_fs_types.c +++ b/lib/tst_supported_fs_types.c @@ -33,6 +33,11 @@ static const char *const fs_type_whitelist[] = { NULL }; +static const cahr *const fs_type_fuse_blacklist[] = { + "bcachefs", + NULL, +}; + static const char *fs_types[ARRAY_SIZE(fs_type_whitelist)]; static int has_mkfs(const char *fs_type) @@ -96,6 +101,11 @@ static enum tst_fs_impl has_kernel_support(const char *fs_type) SAFE_RMDIR(template); + if (tst_fs_in_skiplist(fs_type, tst_fs_type_fuse_blacklist)) { + tst_res("Skipping %s because of FUSE blacklist", fs_type); + return TST_FS_UNSUPPORTED; + } + /* Is FUSE supported by kernel? */ if (fuse_supported == -1) { ret = open("/dev/fuse", O_RDWR); > /* Is FUSE supported by kernel? */ > if (fuse_supported == -1) { > ret = open("/dev/fuse", O_RDWR); -- Cyril Hrubis chrubis@suse.cz