From: Matthew Wilcox <willy@infradead.org>
To: "Pankaj Raghav (Samsung)" <kernel@pankajraghav.com>
Cc: Brian Foster <bfoster@redhat.com>,
Kent Overstreet <kent.overstreet@linux.dev>,
linux-bcachefs@vger.kernel.org, linux-kernel@vger.kernel.org,
Pankaj Raghav <p.raghav@samsung.com>
Subject: Re: [PATCH 1/2] bcachefs: use FGP_WRITEBEGIN instead of combining individual flags
Date: Fri, 14 Jun 2024 15:36:22 +0100 [thread overview]
Message-ID: <ZmxVZiveDdzyByTQ@casper.infradead.org> (raw)
In-Reply-To: <20240614105031.57032-2-kernel@pankajraghav.com>
On Fri, Jun 14, 2024 at 10:50:30AM +0000, Pankaj Raghav (Samsung) wrote:
> ret = bch2_filemap_get_contig_folios_d(mapping, pos, end,
> - FGP_LOCK|FGP_WRITE|FGP_STABLE|FGP_CREAT,
> - mapping_gfp_mask(mapping),
> - &fs);
> + FGP_WRITEBEGIN,
> + mapping_gfp_mask(mapping), &fs);
Don't change the indentation here. In the next patch it makes the
lines too long.
In general, don't change the indentation. It's been one of the biggest
pains of the folio conversion. "Oh, you changed the name of this
function and now the arguments don't line up". Don't line up the
arguments with the opening paren.
next prev parent reply other threads:[~2024-06-14 14:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-14 10:50 [PATCH 0/2] improve buffered write performance with fgf order hint Pankaj Raghav (Samsung)
2024-06-14 10:50 ` [PATCH 1/2] bcachefs: use FGP_WRITEBEGIN instead of combining individual flags Pankaj Raghav (Samsung)
2024-06-14 14:36 ` Matthew Wilcox [this message]
2024-06-14 16:22 ` Pankaj Raghav (Samsung)
2024-06-14 10:50 ` [PATCH 2/2] bcachefs: set fgf order hint before starting a buffered write Pankaj Raghav (Samsung)
2024-06-14 14:50 ` [PATCH 0/2] improve buffered write performance with fgf order hint Kent Overstreet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZmxVZiveDdzyByTQ@casper.infradead.org \
--to=willy@infradead.org \
--cc=bfoster@redhat.com \
--cc=kent.overstreet@linux.dev \
--cc=kernel@pankajraghav.com \
--cc=linux-bcachefs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=p.raghav@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox