From: AP <lkml@inml.grue.cc>
To: Camila Alvarez <cam.alvarez.i@gmail.com>
Cc: Kent Overstreet <kent.overstreet@linux.dev>,
syzbot+4093905737cf289b6b38@syzkaller.appspotmail.com,
Brian Foster <bfoster@redhat.com>,
linux-bcachefs@vger.kernel.org, linux-kernel@vger.kernel.org,
syzkaller-bugs@googlegroups.com
Subject: Re: [PATCH] bcachefs: WARNING in bch2_fs_journal_stop
Date: Thu, 18 Jul 2024 11:04:30 +1000 [thread overview]
Message-ID: <ZphqHm15yNggNdF-@inml.grue.cc> (raw)
In-Reply-To: <20240717220237.1246673-1-cam.alvarez.i@gmail.com>
On Wed, Jul 17, 2024 at 06:02:39PM -0400, Camila Alvarez wrote:
> diff --git a/fs/bcachefs/journal.c b/fs/bcachefs/journal.c
> index 10b19791ec98..7bbbf4b149e9 100644
> --- a/fs/bcachefs/journal.c
> +++ b/fs/bcachefs/journal.c
> @@ -1201,7 +1201,7 @@ int bch2_fs_journal_start(struct journal *j, u64 cur_seq)
> struct journal_replay *i, **_i;
> struct genradix_iter iter;
> bool had_entries = false;
> - u64 last_seq = cur_seq, nr, seq;
> + u64 last_written_seq = cur_seq - 1, last_seq = cur_seq - 1, nr, seq;
Spaces not tabs. I think consistency would be wanted so should be a tab.
AP
next prev parent reply other threads:[~2024-07-18 1:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-17 22:02 [PATCH] bcachefs: WARNING in bch2_fs_journal_stop Camila Alvarez
2024-07-18 1:04 ` AP [this message]
2024-07-18 21:24 ` Kent Overstreet
2024-07-18 22:42 ` Camila Alvarez Inostroza
2024-07-18 22:45 ` Kent Overstreet
2024-07-18 22:49 ` Camila Alvarez Inostroza
2024-07-18 22:53 ` Kent Overstreet
2024-07-18 23:15 ` Camila Alvarez Inostroza
2024-08-02 1:51 ` Camila Alvarez Inostroza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZphqHm15yNggNdF-@inml.grue.cc \
--to=lkml@inml.grue.cc \
--cc=bfoster@redhat.com \
--cc=cam.alvarez.i@gmail.com \
--cc=kent.overstreet@linux.dev \
--cc=linux-bcachefs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=syzbot+4093905737cf289b6b38@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox