Re: [PATCH 1/2] bcachefs: do not use PF_MEMALLOC_NORECLAIM

kernel test robot
2024-08-27T02:23:46Z

Hi Michal,

kernel test robot noticed the following build warnings:

[auto build test WARNING on akpm-mm/mm-everything]
[also build test WARNING on tip/sched/core brauner-vfs/vfs.all linus/master v6.11-rc5]
[cannot apply to next-20240826]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Michal-Hocko/bcachefs-do-not-use-PF_MEMALLOC_NORECLAIM/20240826-171013
base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
patch link: https://lore.kernel.org/r/20240826085347.1152675-2-mhocko%40kernel.org
patch subject: [PATCH 1/2] bcachefs: do not use PF_MEMALLOC_NORECLAIM
config: i386-buildonly-randconfig-003-20240827 (https://download.01.org/0day-ci/archive/20240827/202408271041.5IWf4ZQC-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240827/202408271041.5IWf4ZQC-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202408271041.5IWf4ZQC-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> security/security.c:664: warning: Function parameter or struct member 'gfp' not described in 'lsm_inode_alloc'
>> security/security.c:1586: warning: Function parameter or struct member 'gfp' not described in 'security_inode_alloc'

vim +664 security/security.c

33bf60cabcc768 Casey Schaufler 2018-11-12 654
afb1cbe37440c7 Casey Schaufler 2018-09-21 655 /**
afb1cbe37440c7 Casey Schaufler 2018-09-21 656 * lsm_inode_alloc - allocate a composite inode blob
afb1cbe37440c7 Casey Schaufler 2018-09-21 657 * @inode: the inode that needs a blob
afb1cbe37440c7 Casey Schaufler 2018-09-21 658 *
afb1cbe37440c7 Casey Schaufler 2018-09-21 659 * Allocate the inode blob for all the modules
afb1cbe37440c7 Casey Schaufler 2018-09-21 660 *
afb1cbe37440c7 Casey Schaufler 2018-09-21 661 * Returns 0, or -ENOMEM if memory can't be allocated.
afb1cbe37440c7 Casey Schaufler 2018-09-21 662 */
b2ce84652b3193 Michal Hocko 2024-08-26 663 int lsm_inode_alloc(struct inode *inode, gfp_t gfp)
afb1cbe37440c7 Casey Schaufler 2018-09-21 @664 {
afb1cbe37440c7 Casey Schaufler 2018-09-21 665 if (!lsm_inode_cache) {
afb1cbe37440c7 Casey Schaufler 2018-09-21 666 inode->i_security = NULL;
afb1cbe37440c7 Casey Schaufler 2018-09-21 667 return 0;
afb1cbe37440c7 Casey Schaufler 2018-09-21 668 }
afb1cbe37440c7 Casey Schaufler 2018-09-21 669
b2ce84652b3193 Michal Hocko 2024-08-26 670 inode->i_security = kmem_cache_zalloc(lsm_inode_cache, gfp);
afb1cbe37440c7 Casey Schaufler 2018-09-21 671 if (inode->i_security == NULL)
afb1cbe37440c7 Casey Schaufler 2018-09-21 672 return -ENOMEM;
afb1cbe37440c7 Casey Schaufler 2018-09-21 673 return 0;
afb1cbe37440c7 Casey Schaufler 2018-09-21 674 }
afb1cbe37440c7 Casey Schaufler 2018-09-21 675

--
0-DAY CI Kernel Test Service