Re: [PATCH 3/7] vfs: convert vfs inode iterators to super_iter_inodes_unsafe()

Dave Chinner
2024-10-03T10:45:40Z

On Thu, Oct 03, 2024 at 12:14:57AM -0700, Christoph Hellwig wrote:
> > diff --git a/block/bdev.c b/block/bdev.c
> > index 33f9c4605e3a..b5a362156ca1 100644
> > --- a/block/bdev.c
> > +++ b/block/bdev.c
> > @@ -472,16 +472,28 @@ void bdev_drop(struct block_device *bdev)
> > iput(BD_INODE(bdev));
> > }
> >
> > +static int bdev_pages_count(struct inode *inode, void *data)
>
> This are guaranteed to operate on the bdev superblock, so just
> hardcoding the s_inodes list seems fine here as it keeps the code
> much simpler.

Maybe, but right now I want to remove all external accesses to
sb->s_inodes. This isn't performance critical, and we can revisit
how the bdev sb tracks inodes when we move to per-sb inode
caches....

-Dave.
--
Dave Chinner
david@fromorbit.com