From: "Colin King (gmail)" <colin.i.king@gmail.com>
To: Kent Overstreet <kent.overstreet@linux.dev>
Cc: Brian Foster <bfoster@redhat.com>,
linux-bcachefs@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] bcachefs: remove redundant assignment to variable ret
Date: Thu, 22 Feb 2024 00:08:28 +0000 [thread overview]
Message-ID: <cfa4cd82-67e9-4483-9c35-a425859f4a21@gmail.com> (raw)
In-Reply-To: <3qaoftjgf7p2ugutl524b3yin7pqpjrkftjx3frunhduf3so66@tjhcdoq6unk3>
On 22/02/2024 00:04, Kent Overstreet wrote:
> On Wed, Feb 21, 2024 at 11:52:03AM +0000, Colin Ian King wrote:
>> Variable ret is being assigned a value that is never read, it is
>> being re-assigned a couple of statements later on. The assignment
>> is redundant and can be removed.
>>
>> Cleans up clang scan build warning:
>> fs/bcachefs/super-io.c:806:2: warning: Value stored to 'ret' is
>> never read [deadcode.DeadStores]
>>
>> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
>
> I'll take this, but - entirely too much of the traffic on this list is
> getting taken up by static analyzer bullshit, we need to cut down on
> this
I'll back off then.
Colin
next prev parent reply other threads:[~2024-02-22 0:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-21 11:52 [PATCH][next] bcachefs: remove redundant assignment to variable ret Colin Ian King
2024-02-21 13:37 ` Brian Foster
2024-02-22 0:04 ` Kent Overstreet
2024-02-22 0:08 ` Colin King (gmail) [this message]
2024-02-22 0:13 ` Kent Overstreet
2024-02-22 5:24 ` Dan Carpenter
2024-02-22 6:37 ` Kent Overstreet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cfa4cd82-67e9-4483-9c35-a425859f4a21@gmail.com \
--to=colin.i.king@gmail.com \
--cc=bfoster@redhat.com \
--cc=kent.overstreet@linux.dev \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-bcachefs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox