Re: [PATCH v5 16/18] xfs: add pre-content fsnotify hook for write faults

Amir Goldstein
2024-09-05T08:29:17Z

On Wed, Sep 4, 2024 at 10:29 PM Josef Bacik <josef@toxicpanda.com> wrote:
>
> xfs has it's own handling for write faults, so we need to add the
> pre-content fsnotify hook for this case. Reads go through filemap_fault
> so they're handled properly there.
>
> Signed-off-by: Josef Bacik <josef@toxicpanda.com>
> ---
> fs/xfs/xfs_file.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c
> index 4cdc54dc9686..3e385756017f 100644
> --- a/fs/xfs/xfs_file.c
> +++ b/fs/xfs/xfs_file.c
> @@ -1283,6 +1283,10 @@ xfs_write_fault(
> unsigned int lock_mode = XFS_MMAPLOCK_SHARED;
> vm_fault_t ret;
>
> + ret = filemap_fsnotify_fault(vmf);
> + if (unlikely(ret))
> + return ret;
> +
> sb_start_pagefault(inode->i_sb);
> file_update_time(vmf->vma->vm_file);
>
> --
> 2.43.0
>

The end result is so much nicer than early sketches ;)

Reviewed-by: Amir Goldstein <amir73il@gmail.com>

Thanks,
Amir.