Re: [PATCH v5 00/18] fanotify: add pre-content hooks

Amir Goldstein
2024-09-05T08:33:26Z

On Wed, Sep 4, 2024 at 10:29 PM Josef Bacik <josef@toxicpanda.com> wrote:
>
> v4: https://lore.kernel.org/linux-fsdevel/cover.1723670362.git.josef@toxicpanda.com/
> v3: https://lore.kernel.org/linux-fsdevel/cover.1723228772.git.josef@toxicpanda.com/
> v2: https://lore.kernel.org/linux-fsdevel/cover.1723144881.git.josef@toxicpanda.com/
> v1: https://lore.kernel.org/linux-fsdevel/cover.1721931241.git.josef@toxicpanda.com/
>
> v4->v5:
> - Cleaned up the various "I'll fix it on commit" notes that Jan made since I had
> to respin the series anyway.
> - Renamed the filemap pagefault helper for fsnotify per Christians suggestion.
> - Added a FS_ALLOW_HSM flag per Jan's comments, based on Amir's rough sketch.
> - Added a patch to disable btrfs defrag on pre-content watched files.
> - Added a patch to turn on FS_ALLOW_HSM for all the file systems that I tested.

My only nits are about different ordering of the FS_ALLOW_HSM patches
I guess as the merge window is closing in, Jan could do these trivial
reorders on commit, based on his preference (?).

> - Added two fstests (which will be posted separately) to validate everything,
> re-validated the series with btrfs, xfs, ext4, and bcachefs to make sure I
> didn't break anything.

Very cool!

Thanks again for the "productization" of my patches :)
Amir.