From: Hongbo Li <lihongbo22@huawei.com>
To: David Disseldorp <ddiss@suse.de>,
Kent Overstreet <kent.overstreet@linux.dev>
Cc: <linux-bcachefs@vger.kernel.org>, Martin Doucha <martin.doucha@suse.com>
Subject: Re: [PATCH resend v2] bcachefs: reject unknown mount options
Date: Mon, 23 Sep 2024 14:07:46 +0800 [thread overview]
Message-ID: <e05fef02-dfa9-4ead-873b-e5083b27cbab@huawei.com> (raw)
In-Reply-To: <20240923035903.32589261.ddiss@suse.de>
On 2024/9/23 11:59, David Disseldorp wrote:
> On Sat, 21 Sep 2024 19:13:31 -0400, Kent Overstreet wrote:
>
>> I applied this and got some new failures in the CI - it seems something
>> is broken in remount.
> ...
>> 00163 bcachefs: bch2_parse_one_mount_opt() Bad mount option rwerrors
>> 00163 Error: Invalid argument
>> 00163 Error 1 at /host//home/testdashboard/ktest/tests/fs/bcachefs/ec.ktest 32 from: mount -o remount,ro /mnt, exiting
>> 00163 Error 1 at /host/home/testdashboard/ktest/tests/prelude.sh 269 from: ( set -e; run_test $i ), exiting
>> 00163
>> 00163 ========= FAILED ec_small in 2s
>>
>> The test is just doing
>> mount -o remount,ro /mnt
>>
>> Thomas, this is likely something you introduced, think you could take a
>> look?
>
> Thanks for the details. "mount -o remount,ro <mnt>" works fine for me,
> and I'm not aware of anything that could be providing the "rwerrors"
It seems rw, errors=xxx which misses a comma.
> parameter. Which version of mount / util-linux is used here?
next prev parent reply other threads:[~2024-09-23 6:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-17 1:39 [PATCH resend v2] bcachefs: reject unknown mount options David Disseldorp
2024-09-21 23:13 ` Kent Overstreet
2024-09-23 3:59 ` David Disseldorp
2024-09-23 6:07 ` Hongbo Li [this message]
2024-09-23 9:05 ` Hongbo Li
2024-10-10 18:33 ` Janpieter Sollie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e05fef02-dfa9-4ead-873b-e5083b27cbab@huawei.com \
--to=lihongbo22@huawei.com \
--cc=ddiss@suse.de \
--cc=kent.overstreet@linux.dev \
--cc=linux-bcachefs@vger.kernel.org \
--cc=martin.doucha@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox