Re: WARNING in hsr_addr_subst_dest

Re: WARNING in hsr_addr_subst_dest

[syzbot]

syzbot has bisected this bug to:

commit ab42f35d9cb5ac49b5a2a11f940e74f58f207280
Author: Ming Lei <ming.lei@redhat.com>
Date:   Fri May 26 11:53:19 2017 +0000

     blk-mq: merge bio into sw queue before plugging

bisection log:  https://syzkaller.appspot.com/x/bisect.txt?x=1681996f200000
start commit:   ab42f35d blk-mq: merge bio into sw queue before plugging
git tree:       upstream
final crash:    https://syzkaller.appspot.com/x/report.txt?x=1581996f200000
console output: https://syzkaller.appspot.com/x/log.txt?x=1181996f200000
kernel config:  https://syzkaller.appspot.com/x/.config?x=5e7dc790609552d7
dashboard link: https://syzkaller.appspot.com/bug?extid=b92e4f1472a54e1c7dec
userspace arch: amd64
syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=107db700c00000
C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=12304827400000

Reported-by: syzbot+b92e4f1472a54e1c7dec@syzkaller.appspotmail.com
Fixes: ab42f35d ("blk-mq: merge bio into sw queue before plugging")

Re: WARNING in hsr_addr_subst_dest

[Oliver Hartkopp]

Hi all,

I'm not sure why a Kernel 4.12.0-rc2+ is used here, but I do not get any 
problems on the my latest 5.0.0-06622-g1fc1cd8399ab tree and I strongly 
assume this patch showing up in 4.12-rc6

https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit?id=74b7b490886852582d986a33443c2ffa50970169

fixes the problem.

Best regards,
Oliver

On 3/12/19 7:27 AM, syzbot wrote:
> syzbot has bisected this bug to:
> 
> commit ab42f35d9cb5ac49b5a2a11f940e74f58f207280
> Author: Ming Lei <ming.lei@redhat.com>
> Date:   Fri May 26 11:53:19 2017 +0000
> 
>      blk-mq: merge bio into sw queue before plugging
> 
> bisection log:  https://syzkaller.appspot.com/x/bisect.txt?x=1681996f200000
> start commit:   ab42f35d blk-mq: merge bio into sw queue before plugging
> git tree:       upstream
> final crash:    https://syzkaller.appspot.com/x/report.txt?x=1581996f200000
> console output: https://syzkaller.appspot.com/x/log.txt?x=1181996f200000
> kernel config:  https://syzkaller.appspot.com/x/.config?x=5e7dc790609552d7
> dashboard link: 
> https://syzkaller.appspot.com/bug?extid=b92e4f1472a54e1c7dec
> userspace arch: amd64
> syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=107db700c00000
> C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=12304827400000
> 
> Reported-by: syzbot+b92e4f1472a54e1c7dec@syzkaller.appspotmail.com
> Fixes: ab42f35d ("blk-mq: merge bio into sw queue before plugging")

Re: WARNING in hsr_addr_subst_dest

[Dmitry Vyukov]

On Tue, Mar 12, 2019 at 1:03 PM Oliver Hartkopp <socketcan@hartkopp.net> wrote:
>
> Hi all,
>
> I'm not sure why a Kernel 4.12.0-rc2+ is used here, but I do not get any
> problems on the my latest 5.0.0-06622-g1fc1cd8399ab tree and I strongly
> assume this patch showing up in 4.12-rc6
>
> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit?id=74b7b490886852582d986a33443c2ffa50970169
>
> fixes the problem.
>
> Best regards,
> Oliver

Hi Oliver,

You can see how bisection progressed and got to 4.12.0-rc2+ in the
bisection log.

The commit that it come up with looks unrelated.
I've started collecting such cases at:
https://github.com/google/syzkaller/issues/1051
and added for this case:

=====
Bisected to wrong commit.
Root cause: broken kernel boots, bugs that happen on all tests.
Boot is broken for several releases with "WARNING in hsr_forward_skb",
this switches to a bug that happens during every test "INFO: trying to
register non-static key in can_notifier", which then leads to a
completely random commit.
=====


> > commit ab42f35d9cb5ac49b5a2a11f940e74f58f207280
> > Author: Ming Lei <ming.lei@redhat.com>
> > Date:   Fri May 26 11:53:19 2017 +0000
> >
> >      blk-mq: merge bio into sw queue before plugging
> >
> > bisection log:  https://syzkaller.appspot.com/x/bisect.txt?x=1681996f200000
> > start commit:   ab42f35d blk-mq: merge bio into sw queue before plugging
> > git tree:       upstream
> > final crash:    https://syzkaller.appspot.com/x/report.txt?x=1581996f200000
> > console output: https://syzkaller.appspot.com/x/log.txt?x=1181996f200000
> > kernel config:  https://syzkaller.appspot.com/x/.config?x=5e7dc790609552d7
> > dashboard link:
> > https://syzkaller.appspot.com/bug?extid=b92e4f1472a54e1c7dec
> > userspace arch: amd64
> > syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=107db700c00000
> > C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=12304827400000
> >
> > Reported-by: syzbot+b92e4f1472a54e1c7dec@syzkaller.appspotmail.com
> > Fixes: ab42f35d ("blk-mq: merge bio into sw queue before plugging")
>
> --
> You received this message because you are subscribed to the Google Groups "syzkaller-bugs" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to syzkaller-bugs+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/syzkaller-bugs/11a39c4b-9ac1-e55e-1773-534248a1d1d8%40hartkopp.net.
> For more options, visit https://groups.google.com/d/optout.

Re: WARNING in hsr_addr_subst_dest

[syzbot]

syzbot suspects this bug was fixed by commit:

commit 4b793acdca0050739b99ace6a8b9e7f717f57c6b
Author: Taehee Yoo <ap420073@gmail.com>
Date:   Fri Feb 28 18:01:46 2020 +0000

    hsr: use netdev_err() instead of WARN_ONCE()

bisection log:  https://syzkaller.appspot.com/x/bisect.txt?x=130746ffe00000
start commit:   ea200dec Merge tag 'armsoc-fixes' of git://git.kernel.org/..
git tree:       upstream
kernel config:  https://syzkaller.appspot.com/x/.config?x=dcf10bf83926432a
dashboard link: https://syzkaller.appspot.com/bug?extid=b92e4f1472a54e1c7dec
syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=14b5cafee00000
C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=12574271e00000

If the result looks correct, please mark the bug fixed by replying with:

#syz fix: hsr: use netdev_err() instead of WARN_ONCE()

For information about bisection process see: https://goo.gl/tpsmEJ#bisection