From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0CD9C0015E for ; Fri, 30 Jun 2023 04:45:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230079AbjF3Epj (ORCPT ); Fri, 30 Jun 2023 00:45:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58190 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229522AbjF3Epi (ORCPT ); Fri, 30 Jun 2023 00:45:38 -0400 Received: from mail.nsr.re.kr (unknown [210.104.33.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E88CF2118; Thu, 29 Jun 2023 21:45:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; s=LIY0OQ3MUMW6182UNI14; d=nsr.re.kr; t=1688100197; c=relaxed/relaxed; h=content-type:date:from:message-id:mime-version:subject:to; bh=PZP6GR6XyvR4JOR6xXLruJf7U2QaWCAiYJVe4SwxDx4=; b=ke7Sb1DSwpOtg8xjStsNmBdNSxID+K4HQmOdeQLNsB7dbXQm5VX7l59tVWx6bfdvJPuujXlxmjvKoVX6EL0QcTMkRSIVgGRv8PSXn7E3NcCcuprAGBlUV0NFPY23g+vbEvxO6EX/4eu4DCWmlGJGS60JnEIZssiEHCMp09wH2DY5W5XiJsbfFA9UkUh/2hcQ9wLWN35RQui4ZsQcNoIiFVSYSV7hq31mUmawTziXrGo6TGFTPOL+VUZtqcTWPfORlj4hE3PayNQ/58ouwh+jbaiXb4DHesz03RcAxl3k3DjBnRuTOmWqZPu04akUVnzGPxu4lt3X535aw0sEVORfjA== Received: from 210.104.33.70 (nsr.re.kr) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128 bits)) by mail.nsr.re.kr with SMTP; Fri, 30 Jun 2023 13:43:02 +0900 Received: from 192.168.155.188 ([192.168.155.188]) by mail.nsr.re.kr (Crinity Message Backbone-7.0.1) with SMTP ID 506; Fri, 30 Jun 2023 13:45:09 +0900 (KST) From: Dongsoo Lee To: 'Eric Biggers' Cc: 'Herbert Xu' , "'David S. Miller'" , 'Jens Axboe' , "'Theodore Y. Ts'o'" , 'Jaegeuk Kim' , linux-crypto@vger.kernel.org, linux-block@vger.kernel.org, linux-fscrypt@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230626084703.907331-1-letrhee@nsr.re.kr> <20230626084703.907331-5-letrhee@nsr.re.kr> <20230628063830.GA7920@sol.localdomain> <000901d9aa70$a228c420$e67a4c60$@nsr.re.kr> <20230630025914.GB1088@sol.localdomain> In-Reply-To: <20230630025914.GB1088@sol.localdomain> Subject: RE: [PATCH v3 4/4] fscrypt: Add LEA-256-XTS, LEA-256-CTS support Date: Fri, 30 Jun 2023 13:45:10 +0900 Message-ID: <001201d9ab0d$a6ab50b0$f401f210$@nsr.re.kr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQHHxDRlmstc7qqNSJFY4M8BkkyX4gFqzZG4AcdR3rkCVVeuvQFbPgFSr497xkA= Content-Language: ko Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Thu, Jun 29, 2023 at 19:59:14 -0700, Eric Biggers wrote: > I don't think that really addresses my comment, due to the second sentence. I > understand that you would like to advertise the performance of LEA. But as I > mentioned, it's not yet realized in the kernel crypto API, and in the context of > fscrypt it won't really bring anything new to the table anyway. For now I think > LEA is best described as a "national pride cipher" alongside SM4... Keep in > mind, it can always be changed later if new use cases come up. > > Could you just omit the documentation update from your patch? I actually need > to rework the whole "Encryption modes and usage" section anyway since it's > growing a bit unwieldy, with 6 different combinations of encryption modes now > supported. The information needs to be organized better. It currently reads > like a list, and it might be hard for users to understand which setting to use. > > I'll add on a patch that does that and adds the mention of LEA support. > > - Eric Thanks for the feedback. We'll remove the documentation and submit the next version.