From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f45.google.com (mail-io1-f45.google.com [209.85.166.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 17A3B14A0B8 for ; Tue, 5 Nov 2024 15:54:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730822084; cv=none; b=p/+Fc3JXYHAGKJ1FZUTVsR86IIiiq2fvmE+i0qVupdAumS6fHNQEoTGvL4xJPpdFDuXBR4pGsZR5idvNQbwiyIOfVkQSoeNGZGRblihsqIp+JdSvHin52C8Zojouspb44CU9BH9USdH3uBvR3bwVUBLRRg9ANvnB2+UU81Kl/Vw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730822084; c=relaxed/simple; bh=GmDcH9fH5CQZbjDIsLa9zbmwEVBfpSGCcfdtLHzHg2k=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=THDD5GV6TIksXEPenOk1QGZNvAnoi3JgiFm3kc38qsW8XZfOi1oQHovrbspCApxXq9l9i4f/I8WS9uQxnu5EGE3L62ERuK2ElI6mbFNsCTzdrO3vU9xzaUKr/5qdr61K9lJP5RrSWsOW5BNgAKYBq/c+ra9q7KiwPuctrnxGxCc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=0izHAbJR; arc=none smtp.client-ip=209.85.166.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="0izHAbJR" Received: by mail-io1-f45.google.com with SMTP id ca18e2360f4ac-83ab94452a7so240246439f.3 for ; Tue, 05 Nov 2024 07:54:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1730822082; x=1731426882; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=UMblOGMbazjLmtJYQwpwJ6Rzx7y2x3BU21hGqMAlPmE=; b=0izHAbJRVwll4z5mbE1BJzWzmBuFDr0o06EdNjUl2w1IfJVIfdpoMcLOaKuyvGyAFb RqaY3jIURqOVA8rBSG+Ib+GFBtydW7P0JKTt9Xyl3EVPByCKgwdypKq+uD2BQzsKx7Kj SHLO/zgtcNpdtlleYHDv3SwRybnon2a1Wb2l5F040/G3oKxXRX8A1SJV9kUGiRLpjS8/ QfCls6vEa3aF3YctnQjHS3Xsw5nx4ukOKcoCESWaijGy4Zc2jg7DqpPd86i/Edbkd2Rs vyGSwzaYG25kzp9EyVWpqSoyHUQOv1cXHosWs772iAnCtq/10hgnBDspGPx7XiqvaUYn rO5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730822082; x=1731426882; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UMblOGMbazjLmtJYQwpwJ6Rzx7y2x3BU21hGqMAlPmE=; b=pBWn/nii4GIx6zTOUgmHVs2cz+Xc51tUWHhmPrbmCMp3xMYqjNgbqw0JArnzryCB+P yo52kJWW04WederIlJ0vS7arNTVk/al9htgaP8Mwp5nDXlMA9IJP+w1GnyJRay8FpJOG 18pDwhUcZakEcWbqHAkw5R6q24lXo6mFvEPcoP9GSQB0fHulPXczXiz+KhO7IE6uwjfP /lSC97tErJIhmYuMg2gU6xMEXrn7rxaLzED7ikQsLpYXpq7bzGe0qEEUybrjath5J66F E+NUsocR/DCIKgPf1V8w90WQ+GlQHUTdiDzipjcd1jv//O56R4X1HeNKdW4buUH7oh1A y3FQ== X-Forwarded-Encrypted: i=1; AJvYcCVDsHZ18+cjUFe6vKJ/qOFpYY3gLrrzKc0BdyWBkkn27ZYJWqW/+mPoPwxTYO0JYTJam2IB3kDCQN7N9A==@vger.kernel.org X-Gm-Message-State: AOJu0YxmrIIi24gXnQT9rYCXHKGZF48YOWrvriRINFR/mnmY2ccI+RxA /HHqsyEx3OUH+V9lFQSSXgePe0JgYhsBBXg7sOifwgDhAlMNITDxqk6NqhXulyU= X-Google-Smtp-Source: AGHT+IHx4XYVdOEQB1fuv7KmfyxWz/fsEeyxbyhyP0PnEBcHFIT24et7k1hv3V2APh3M3l0s92OUBw== X-Received: by 2002:a05:6602:2cc8:b0:83a:f447:f0b9 with SMTP id ca18e2360f4ac-83b56712446mr2807793039f.9.1730822082167; Tue, 05 Nov 2024 07:54:42 -0800 (PST) Received: from [192.168.1.116] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id ca18e2360f4ac-83b67aeacfdsm271817939f.9.2024.11.05.07.54.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Nov 2024 07:54:41 -0800 (PST) Message-ID: <00618fda-985d-4d6b-ada1-2d93a5380492@kernel.dk> Date: Tue, 5 Nov 2024 08:54:40 -0700 Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [ANNOUNCE] work tree for untorn filesystem writes To: "Darrick J. Wong" Cc: Theodore Ts'o , Carlos Maiolino , "Ritesh Harjani (IBM)" , John Garry , brauner@kernel.org, Catherine Hoang , linux-ext4@vger.kernel.org, Jan Kara , Christoph Hellwig , Ojaswin Mujoo , linux-block@vger.kernel.org, Dave Chinner , linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org References: <20241105004341.GO21836@frogsfrogsfrogs> <72515c41-4313-4287-97cc-040ec143b3c5@kernel.dk> <20241105150812.GA227621@mit.edu> <5557bb8e-0ab8-4346-907e-a6cfea1dabf8@kernel.dk> <20241105154044.GD2578692@frogsfrogsfrogs> Content-Language: en-US From: Jens Axboe In-Reply-To: <20241105154044.GD2578692@frogsfrogsfrogs> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/5/24 8:40 AM, Darrick J. Wong wrote: > On Tue, Nov 05, 2024 at 08:11:52AM -0700, Jens Axboe wrote: >> On 11/5/24 8:08 AM, Theodore Ts'o wrote: >>> On Tue, Nov 05, 2024 at 05:52:05AM -0700, Jens Axboe wrote: >>>> >>>> Why is this so difficult to grasp? It's a pretty common method for >>>> cross subsystem work - it avoids introducing conflicts when later >>>> work goes into each subsystem, and freedom of either side to send a >>>> PR before the other. >>>> >>>> So please don't start committing the patches again, it'll just cause >>>> duplicate (and empty) commits in Linus's tree. >>> >>> Jens, what's going on is that in order to test untorn (aka "atomic" >>> although that's a bit of a misnomer) writes, changes are needed in the >>> block, vfs, and ext4 or xfs git trees. So we are aware that you had >>> taken the block-related patches into the block tree. What Darrick has >>> done is to apply the the vfs patches on top of the block commits, and >>> then applied the ext4 and xfs patches on top of that. >> >> And what I'm saying is that is _wrong_. Darrick should be pulling the >> branch that you cut from my email: >> >> for-6.13/block-atomic >> >> rather than re-applying patches. At least if the intent is to send that >> branch to Linus. But even if it's just for testing, pretty silly to have >> branches with duplicate commits out there when the originally applied >> patches can just be pulled in. > > I *did* start my branch at the end of your block-atomic branch. > > Notice how the commits I added yesterday have a parent commitid of > 1eadb157947163ca72ba8963b915fdc099ce6cca, which is the head of your > for-6.13/block-atomic branch? Ah that's my bad, I didn't see a merge commit, so assumed it was just applied on top. Checking now, yeah it does look like it's done right! Would've been nicer on top of current -rc and with a proper merge commit, but that's really more of a style preference. Though -rc1 is pretty early... > But, it's my fault for not explicitly stating that I did that. One of > the lessons I apparently keep needing to learn is that senior developers > here don't actually pull and examine the branches I link to in my emails > before hitting Reply All to scold. You obviously didn't. I did click the link, in my defense it was on the phone this morning. And this wasn't meant as a scolding, nor do I think my wording really implies any scolding. My frustration was that I had explained this previously, and this seemed like another time to do the exact same. So my apologies if it came off like that, was not the intent. -- Jens Axboe