From: Jens Axboe <axboe@kernel.dk>
To: Ming Lei <ming.lei@redhat.com>
Cc: linux-block@vger.kernel.org, Yi Zhang <yi.zhang@redhat.com>
Subject: Re: [PATCH] block: mark flush request as IDLE when it is really finished
Date: Fri, 13 Nov 2020 14:24:37 -0700 [thread overview]
Message-ID: <00aa56e6-dfa4-bfa5-c0bf-32412b4393e2@kernel.dk> (raw)
In-Reply-To: <20201113134448.1074373-1-ming.lei@redhat.com>
On 11/13/20 6:44 AM, Ming Lei wrote:
> For avoiding use-after-free on flush request, we call its .end_io() from
> both timeout code path and __blk_mq_end_request().
>
> When flush request's ref doesn't drop to zero, it is still used, we
> can't mark it as IDLE, so fix it by marking IDLE when its refcount drops
> to zero really.
Applied, thanks.
--
Jens Axboe
prev parent reply other threads:[~2020-11-13 21:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-13 13:44 [PATCH] block: mark flush request as IDLE when it is really finished Ming Lei
2020-11-13 21:24 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00aa56e6-dfa4-bfa5-c0bf-32412b4393e2@kernel.dk \
--to=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=yi.zhang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox