Re: [PATCH blktests] src/dio-offsets.c: Fix err() usage

[Bart Van Assche <bvanassche@acm.org>]

On 4/4/26 1:35 AM, Shinichiro Kawasaki wrote:
> One thing I found is that one more err(EIO,...) is left in __compare() after
> applying the patch. Should we convert it also into err_errno()? If so, I will
> fold-in the hunk below.
> 
> diff --git a/src/dio-offsets.c b/src/dio-offsets.c
> index 9fc7b92..c40ce68 100644
> --- a/src/dio-offsets.c
> +++ b/src/dio-offsets.c
> @@ -131,7 +131,7 @@ static void __compare(void *a, void *b, size_t size, const char *test)
>   {
>   	if (!memcmp(a, b, size))
>   		return;
> -	err(EIO, "%s: data corruption", test);
> +	err_errno(EIO, "%s: data corruption", test);
>   }
>   #define compare(a, b, size) __compare(a, b, size, __func__)

Folding in this change sounds good to me.

Thanks,

Bart.