public inbox for linux-block@vger.kernel.org
 help / color / mirror / Atom feed
From: "Matias Bjørling" <mb@lightnvm.io>
To: Heiner Litz <hlitz@ucsc.edu>, linux-block@vger.kernel.org
Cc: javier@cnexlabs.com, matias@lightnvm.io
Subject: Re: [PATCH] lightnvm: fix bad block initialization
Date: Fri, 23 Feb 2018 19:45:39 +0100	[thread overview]
Message-ID: <02770a13-9699-aa8d-bcf2-c7aaefe28623@lightnvm.io> (raw)
In-Reply-To: <20180223174016.6104-1-hlitz@ucsc.edu>

On 02/23/2018 06:40 PM, Heiner Litz wrote:
> fix reading bad block device information to correctly setup the per line
> blk_bitmap during lightnvm initialization
> 
> Signed-off-by: Heiner Litz <hlitz@ucsc.edu>
> ---
>   drivers/lightnvm/pblk-init.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/lightnvm/pblk-init.c b/drivers/lightnvm/pblk-init.c
> index 86a94a7faa96..e0eba150ac7e 100644
> --- a/drivers/lightnvm/pblk-init.c
> +++ b/drivers/lightnvm/pblk-init.c
> @@ -461,10 +461,11 @@ static int pblk_bb_line(struct pblk *pblk, struct pblk_line *line,
>   	struct nvm_tgt_dev *dev = pblk->dev;
>   	struct nvm_geo *geo = &dev->geo;
>   	int i, bb_cnt = 0;
> +	int blk_per_lun = geo->nr_chks * geo->plane_mode;
>   
>   	for (i = 0; i < blk_per_line; i++) {
>   		struct pblk_lun *rlun = &pblk->luns[i];
> -		u8 *lun_bb_log = bb_log + i * blk_per_line;
> +		u8 *lun_bb_log = bb_log + i * blk_per_lun;
>   
>   		if (lun_bb_log[line->id] == NVM_BLK_T_FREE)
>   			continue;
> 

Thanks Heiner. Applied.

  reply	other threads:[~2018-02-23 18:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-23 17:40 [PATCH] lightnvm: fix bad block initialization Heiner Litz
2018-02-23 18:45 ` Matias Bjørling [this message]
2018-02-24  9:11   ` Javier Gonzalez
2018-02-24  9:15   ` Javier Gonzalez
  -- strict thread matches above, loose matches on Subject: below --
2018-02-22  8:10 Heiner Litz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=02770a13-9699-aa8d-bcf2-c7aaefe28623@lightnvm.io \
    --to=mb@lightnvm.io \
    --cc=hlitz@ucsc.edu \
    --cc=javier@cnexlabs.com \
    --cc=linux-block@vger.kernel.org \
    --cc=matias@lightnvm.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox