From: Bart Van Assche <bvanassche@acm.org>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Josef Bacik <josef@toxicpanda.com>
Subject: Re: [PATCH v2] nbd: Remove __force casts
Date: Tue, 4 Jun 2024 16:10:27 -0600 [thread overview]
Message-ID: <027dd678-3e49-4510-a67f-38b5a67c1463@acm.org> (raw)
In-Reply-To: <20240604220431.GU1629371@ZenIV>
On 6/4/24 16:04, Al Viro wrote:
> On Tue, Jun 04, 2024 at 03:52:27PM -0600, Bart Van Assche wrote:
>> From: Christoph Hellwig <hch@lst.de>
>>
>> Make it again possible for sparse to verify that blk_status_t and Unix
>> error codes are used in the proper context by making nbd_send_cmd()
>> return a struct instead of an integer.
>
> Not in this version of patch:
>
>> -static int nbd_send_cmd(struct nbd_device *nbd, struct nbd_cmd *cmd, int index)
>> +static blk_status_t nbd_send_cmd(struct nbd_device *nbd, struct nbd_cmd *cmd,
>> + int index)
>
> include/linux/blk_types.h:93:typedef u8 __bitwise blk_status_t;
Thanks for the quick feedback. I will fix the patch description and repost.
Bart.
prev parent reply other threads:[~2024-06-04 22:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-04 21:52 [PATCH v2] nbd: Remove __force casts Bart Van Assche
2024-06-04 22:04 ` Al Viro
2024-06-04 22:10 ` Bart Van Assche [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=027dd678-3e49-4510-a67f-38b5a67c1463@acm.org \
--to=bvanassche@acm.org \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox