From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [PATCH V3 00/17] SCSI: introduce per-host admin queue & enable runtime PM To: Ming Lei Cc: Jens Axboe , linux-block@vger.kernel.org References: <20180913121546.5710-1-ming.lei@redhat.com> <20180916130918.GA9947@ming.t460p> <7e9cfa7a-292a-0c26-0da8-187d961d974a@oracle.com> <20180917120727.GC28349@ming.t460p> From: "jianchao.wang" Message-ID: <0475ffa4-be81-e35f-efe8-6821bada104c@oracle.com> Date: Tue, 18 Sep 2018 09:17:12 +0800 MIME-Version: 1.0 In-Reply-To: <20180917120727.GC28349@ming.t460p> Content-Type: text/plain; charset=utf-8 List-ID: Hi Ming On 09/17/2018 08:07 PM, Ming Lei wrote: >>> This way will delay runtime pm or system suspend until the queue is unfrozen, >>> but it isn't reasonable. >> This interface is for the __scsi_execute only, before we call into function, we should have >> get the device resumed synchronously. > I mean when the queue is frozen, it is reasonable to runtime suspend the queue. However, > blk_queue_preempt_enter() is still waiting for queue becoming unfreezing first. We don't freeze the queue, but set preempt-only mode when suspend the queue. :) Thanks Jianchao