From: Jens Axboe <axboe@kernel.dk>
To: wangjie <wangjie22@lixiang.com>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] block: check disk flag before setting scan bit
Date: Mon, 16 Jan 2023 09:14:55 -0700 [thread overview]
Message-ID: <05a28cc6-0070-9117-368e-ade7561f6727@kernel.dk> (raw)
In-Reply-To: <20230116083832.27305-1-wangjie22@lixiang.com>
On 1/16/23 1:38?AM, wangjie wrote:
> No need to scan partitions for disk who has set flag GENHD_FL_NO_PART in
> driver code. In disk_scan_partitions function, the same checking is
> existing, so we believe this change is reasonable.
>
> In our case, some virtual block devices are not managed by GPT, then scan
> partition operation is not a must. So we set GENHD_FL_NO_PART flag in
> driver intended to avoid partitions being dropped/added.
> But GD_NEED_PART_SCAN bit was still set by bdev_check_media_change, which
> causing problems here.
>
> Signed-off-by: wangjie
Signed-off-by is in the wrong format, and the whole email is badly
mangled...
> ????????????????????????????????????????????????????
> ????????????????????????????????????????????????????
> ???????????????????????????????
This didn't quote well, but the original is also useless. You do realize
you send this email to a public list? Please get rid of it.
--
Jens Axboe
next parent reply other threads:[~2023-01-16 16:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230116083832.27305-1-wangjie22@lixiang.com>
2023-01-16 16:14 ` Jens Axboe [this message]
2023-01-17 7:53 [PATCH] block: check disk flag before setting scan bit Jie Wang
2023-01-17 8:14 ` Christoph Hellwig
[not found] ` <1a61ffce.191e.185bef2aea0.Coremail.wangjie2011cs@163.com>
2023-01-17 8:58 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05a28cc6-0070-9117-368e-ade7561f6727@kernel.dk \
--to=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wangjie22@lixiang.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox