From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [PATCH] blk-mq: remove double set queue_num To: Erics Di Cc: linux-block@vger.kernel.org, Christoph Hellwig , Ming Lei References: From: Jens Axboe Message-ID: <05ed445c-b9a1-7bc8-511b-d915fb0e6d17@kernel.dk> Date: Thu, 22 Jun 2017 08:10:38 -0600 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 List-ID: On 06/22/2017 03:29 AM, Erics Di wrote: > hwctx's queue_num has been set prior call blk_mq_init_hctx, so no need > > set it again. You are right, that is a duplicate setting. But your patch is odd in various ways: 1) Your signed-off-by and sender email (and name) have nothing to do with each other. 2) The patch is severely mangled. How are you sending it? #2 I can manually fix up, but I can't fix up #1. -- Jens Axboe