From: Yufen Yu <yuyufen@huawei.com>
To: Ming Lei <ming.lei@redhat.com>
Cc: Yu Kuai <yukuai3@huawei.com>, Yu Kuai <yukuai1@huaweicloud.com>,
<axboe@kernel.dk>, <linux-block@vger.kernel.org>, <hch@lst.de>,
"zhangyi (F)" <yi.zhang@huawei.com>
Subject: Re: [PATCH] blk-mq: run queue after issuing the last request of the plug list
Date: Tue, 26 Jul 2022 17:20:24 +0800 [thread overview]
Message-ID: <060259de-0168-bd31-ee31-72acbc93bd2b@huawei.com> (raw)
In-Reply-To: <Yt+aSH86dVCA1vux@T590>
On 2022/7/26 15:39, Ming Lei wrote:
> On Tue, Jul 26, 2022 at 01:01:41PM +0800, Yufen Yu wrote:
>>
>>>
>>
>> hi Ming,
>>
>> Here rq2 fail from blk_mq_plug_issue_direct() in blk_mq_flush_plug_list(),
>> not blk_mq_sched_insert_requests
>
> OK, just wondering why Yufen's patch touches
> blk_mq_sched_insert_requests().
>
> Here the issue is in blk_mq_plug_issue_direct() itself, it is wrong to use last
> request of plug list to decide if run queue is needed since all the remained
> requests in plug list may be from other hctxs, and the simplest fix could be pass
> run_queue as true always to blk_mq_request_bypass_insert().
>
OK, thanks for your suggestion and I will send v2.
Thanks,
Yufen
>
> Thanks,
> Ming
>
> .
prev parent reply other threads:[~2022-07-26 9:20 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-18 12:35 [PATCH] blk-mq: run queue after issuing the last request of the plug list Yufen Yu
2022-07-19 9:26 ` Ming Lei
2022-07-19 11:00 ` Yufen Yu
2022-07-23 2:50 ` Yu Kuai
2022-07-25 15:43 ` Ming Lei
2022-07-26 1:08 ` Yu Kuai
2022-07-26 1:46 ` Ming Lei
2022-07-26 2:08 ` Yu Kuai
2022-07-26 2:32 ` Ming Lei
2022-07-26 2:52 ` Yu Kuai
2022-07-26 3:02 ` Ming Lei
2022-07-26 3:14 ` Yu Kuai
2022-07-26 3:21 ` Ming Lei
2022-07-26 3:31 ` Yufen Yu
2022-07-26 3:31 ` Yu Kuai
2022-07-26 4:16 ` Ming Lei
2022-07-26 5:01 ` Yufen Yu
2022-07-26 7:39 ` Ming Lei
2022-07-26 9:20 ` Yufen Yu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=060259de-0168-bd31-ee31-72acbc93bd2b@huawei.com \
--to=yuyufen@huawei.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai1@huaweicloud.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox