From: Bart Van Assche <bvanassche@acm.org>
To: Ming Lei <ming.lei@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Damien Le Moal <dlemoal@kernel.org>
Subject: Re: [PATCH] block: Do not merge if merging is disabled
Date: Thu, 6 Jul 2023 18:50:24 -0700 [thread overview]
Message-ID: <06034722-621b-e06c-53e6-d2151cc07a64@acm.org> (raw)
In-Reply-To: <ZKdebT5VRdr0qxxv@ovpn-8-34.pek2.redhat.com>
On 7/6/23 17:38, Ming Lei wrote:
> Given blk_mq_sched_try_insert_merge is only called from bfq and
> deadline, it may not matter to apply this optimization.
Without this patch, the documentation of the "nomerges" sysfs
attribute is incorrect. I need this patch because I want the
ability to disable merging even if an I/O scheduler has been
selected. As mentioned in the patch description, I discovered
this while I was writing a shell script that submits various
I/O workloads to a block device.
Bart.
next prev parent reply other threads:[~2023-07-07 1:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-06 20:14 [PATCH] block: Do not merge if merging is disabled Bart Van Assche
2023-07-06 23:43 ` Damien Le Moal
2023-07-07 0:38 ` Ming Lei
2023-07-07 1:50 ` Bart Van Assche [this message]
2023-07-07 3:34 ` Damien Le Moal
2023-07-07 13:50 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06034722-621b-e06c-53e6-d2151cc07a64@acm.org \
--to=bvanassche@acm.org \
--cc=axboe@kernel.dk \
--cc=dlemoal@kernel.org \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox