From: Jens Axboe <axboe@kernel.dk>
To: Ben Hutchings <ben@decadent.org.uk>
Cc: Paolo Valente <paolo.valente@linaro.org>, linux-block@vger.kernel.org
Subject: Re: [PATCH 1/2] bfq: Re-enable auto-loading when built as a module
Date: Tue, 29 Aug 2017 10:46:29 -0600 [thread overview]
Message-ID: <06a60078-1592-dc39-a2d9-df3320460bed@kernel.dk> (raw)
In-Reply-To: <1504024458.4448.18.camel@decadent.org.uk>
On 08/29/2017 10:34 AM, Ben Hutchings wrote:
> On Tue, 2017-08-29 at 09:53 -0600, Jens Axboe wrote:
>> On 08/29/2017 09:48 AM, Jens Axboe wrote:
>>> On 08/29/2017 09:28 AM, Ben Hutchings wrote:
>>>> On Tue, 2017-08-29 at 08:31 -0600, Jens Axboe wrote:
>>>>> On Sun, Aug 13 2017, Ben Hutchings wrote:
>>>>>> The block core requests modules with the "-iosched" name
>>>>>> suffix, but
>>>>>> bfq no longer has that suffix. Add an alias.
>>>>>
>>>>> I'd apply these two, but both patches are mangled when saved.
>>>>> It's
>>>>> turning == into =3D and so forth.
>>>>>
>>>>> Care to check your settings and resend?
>>>>
>>>> Just tried saving and applying with 'git am' successfully. I
>>>> think the
>>>> problem is at your end.
>>>
>>> Then yours is the only one, I apply patches people send me all day
>>> long.
>>> Was the case both in tbird and mutt, both of them showed the diffs
>>> as mangled, and they showed up mangled when saved.
>>
>> Here's your email in the archive:
>>
>> https://marc.info/?l=linux-block&m=150264374920778&q=raw
>>
>> Note this part:
>>
>> Content-Transfer-Encoding: quoted-printable
>
> What about it? This is used for every mail with a non-ASCII name in
> it, for example. 'git am' understands it.
What about it? It screws up the patch. Maybe git am understands it, but
it's hard/impossible to read manually. I'm not going to apply anything
that I can't personally read/review easily. Fix your setup, if you are
going to be sending patches.
>> Problem is definitely at your end.
>
> Or perhaps in the middle? Anyway, here are the patches again as an
> mbox.
Feel free to browse other patches on the list, I don't see any that
are quoted-printable. And I'd know, since I generally end up applying
(or at least reviewing) most of them.
--
Jens Axboe
next prev parent reply other threads:[~2017-08-29 16:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-13 17:02 [PATCH 1/2] bfq: Re-enable auto-loading when built as a module Ben Hutchings
2017-08-13 17:03 ` [PATCH 2/2] mq-deadline: Enable auto-loading when built as module Ben Hutchings
2017-08-29 10:45 ` Ming Lei
2017-08-29 10:45 ` [PATCH 1/2] bfq: Re-enable auto-loading when built as a module Ming Lei
2017-08-29 14:31 ` Jens Axboe
2017-08-29 15:28 ` Ben Hutchings
2017-08-29 15:48 ` Jens Axboe
2017-08-29 15:53 ` Jens Axboe
2017-08-29 16:34 ` Ben Hutchings
2017-08-29 16:46 ` Jens Axboe [this message]
2017-08-29 19:49 ` Ben Hutchings
2017-08-29 19:57 ` Jens Axboe
2017-08-29 21:51 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06a60078-1592-dc39-a2d9-df3320460bed@kernel.dk \
--to=axboe@kernel.dk \
--cc=ben@decadent.org.uk \
--cc=linux-block@vger.kernel.org \
--cc=paolo.valente@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox