linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: John Garry <john.g.garry@oracle.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Christoph Hellwig <hch@infradead.org>,
	"Darrick J. Wong" <djwong@kernel.org>,
	linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org,
	linux-block@vger.kernel.org, linux-nvme@lists.infradead.org
Subject: Re: Do we need an opt-in for file systems use of hw atomic writes?
Date: Tue, 15 Jul 2025 09:42:33 +0100	[thread overview]
Message-ID: <072b174d-8efe-49d6-a7e3-c23481fdb3fc@oracle.com> (raw)
In-Reply-To: <20250715060247.GC18349@lst.de>

On 15/07/2025 07:02, Christoph Hellwig wrote:
> On Mon, Jul 14, 2025 at 04:53:49PM +0100, John Garry wrote:
>> I see. I figure that something like a FS_XFLAG could be used for that. But
>> we should still protect bdev fops users as well.
> 
> I'm not sure a XFLAG is all that useful.  It's not really a per-file
> persistent thing.  It's more of a mount option, or better persistent
> mount-option attr like we did for autofsck.

For all these options, the admin must know that the atomic behaviour of 
their disk is as advertised - I am not sure how realistic it is.

Apart from this, it would be nice to have an idea of how to handle the 
NVMe. About this:

" III.	 don't allow atomics on controllers that only report AWUPF and
  	 limit support to controllers that support that more sanely
	 defined NAWUPF"

Would it be possible to also have a driver opt-in for those controllers 
which don't support NAWUPF?

Thanks,
John

  reply	other threads:[~2025-07-15  8:42 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-14 13:17 Do we need an opt-in for file systems use of hw atomic writes? Christoph Hellwig
2025-07-14 13:24 ` Theodore Ts'o
2025-07-14 13:30   ` Christoph Hellwig
2025-07-14 16:04     ` Darrick J. Wong
2025-07-15  6:00       ` Christoph Hellwig
2025-07-15  3:22     ` Martin K. Petersen
2025-07-15  6:00       ` Christoph Hellwig
2025-07-15 12:45         ` Martin K. Petersen
2025-07-14 13:39 ` John Garry
2025-07-14 13:50   ` Christoph Hellwig
2025-07-14 15:53     ` John Garry
2025-07-15  6:02       ` Christoph Hellwig
2025-07-15  8:42         ` John Garry [this message]
2025-07-15  9:03           ` Christoph Hellwig
2025-08-19 11:42             ` John Garry
2025-08-19 13:39               ` Christoph Hellwig
2025-08-19 14:36                 ` John Garry
2025-08-19 14:43                   ` Darrick J. Wong
2025-08-19 14:45                     ` Christoph Hellwig
2025-08-21 14:01               ` Keith Busch
2025-07-15 10:02         ` Christian Brauner
2025-07-15 11:29           ` Christoph Hellwig
2025-07-15 12:20             ` Christian Brauner
2025-07-15 11:58           ` Theodore Ts'o
2025-07-14 20:53 ` Dave Chinner
2025-07-15  6:05   ` Christoph Hellwig
2025-07-15 20:56 ` Keith Busch
2025-07-16  5:50   ` Nilay Shroff

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=072b174d-8efe-49d6-a7e3-c23481fdb3fc@oracle.com \
    --to=john.g.garry@oracle.com \
    --cc=djwong@kernel.org \
    --cc=hch@infradead.org \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).