From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f53.google.com (mail-oo1-f53.google.com [209.85.161.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 16F2B38E8A2 for ; Mon, 12 Oct 2026 20:21:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791836474; cv=none; b=pA/7hdU7TffySEcck2T3tAjTtJy+QikZhIr3GBa1FrEJOLLeGk67YwjzAY782f4ttSKkFJb5Br85C0eOexBXinLYXDjY/DKVtNn0YM3IO4tBQE/rInol31DwoxV+SMIrVDYxOesCPQNUSjG/bfwv15q+bmGkFCGTIdjJR8HNLzE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791836474; c=relaxed/simple; bh=7UIEB3A73ofI1JEPEVW7u76mIWqiduCC1j8GOZ2rTrc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lisT8AjLhPXhPxSDc1m0qIRbb2EfWT78pZtp6Eb/2mc/4DoeqKk/hDnkI0c0TLpU6awiYt67c+xJ0+WDYB6r8XN0jeaIkaLUW39+v+vOw5SfGd/fFlkueZBms+adHrpnTIUES5AMFKM3lzZ+grSwBBd2nfv6MbkNuA84/fbcMcg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20251104.gappssmtp.com header.i=@kernel-dk.20251104.gappssmtp.com header.b=Ge1m9jFg; arc=none smtp.client-ip=209.85.161.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20251104.gappssmtp.com header.i=@kernel-dk.20251104.gappssmtp.com header.b="Ge1m9jFg" Received: by mail-oo1-f53.google.com with SMTP id 006d021491bc7-6d7e06dbcccso1385819eaf.3 for ; Mon, 12 Oct 2026 13:21:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20251104.gappssmtp.com; s=20251104; t=1791836472; x=1792441272; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=7YdOwQKvIOtKNWjhAuzTAXTxb0yaTLWKFCpvhJolByA=; b=Ge1m9jFgPccwqtKXKUzf/OW9C4i080feo3eBI5G1piO4dIiQlPKXOBBUT755ax1gLG 2rAk/BfSyoVo8xWiUu1wnjV6MQB4ykAhBn9bQu+X2AqAxrLemYRv+FoPbfSviQRNR7ip qEbWoBIb15TveaqSvYBMtNhG+ngUuE8RebMGyN5SE4ZzoIC09vjhs5ESts7cHlzW6zLN aXKlvHBCMTFdZZJSBxHXSMlP4FEGJuLdjixGHuF7r3QNTh5nsWJ4r8VuWvV5tBYG6CPp +t11drObYH8uC27P+QB2iYe9A6kVC7Sd+gCo45J1Edt6SozQ+oTDEOSyDzDxZZK/Gm/7 ohTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791836472; x=1792441272; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=7YdOwQKvIOtKNWjhAuzTAXTxb0yaTLWKFCpvhJolByA=; b=aAXH1XEV+SXZZv2QVG4oLk/9NdYTKSKRC5BrE8kq1nUeMdPpu41N9SPDFV/yBZIdtL shihLQnpAWd17VK2z6Tj22N7z/u1KgmaxqTfvFq/1WnGQ/R6Ru2PxIABKxIsompJW7Sw zrzSahq/qMfvlwPBNgpLZ/Huz5AAmyOi3Mh67ZDAM1ZUrnF/ZF0/2pCHNRyziGLTjBrm M37RZxttBAEDBti8xNhEzWR7Hn8DIHP6MRcvBxDuceXs0dEweykezqZZG7kWM2TZWhoG VqAiUsHx69+FxSoG8ygQXh5aDw3HB9gbTOzNSplHARAoFCHUsheAWjNF6p+DPJIjGTUm 3eEQ== X-Forwarded-Encrypted: i=1; AKwUvBxYlJBzJQ2DDeOXl2CqJUShEVi2j8JUky6ZOhBX6n1TNTUuV0DGodnaoVL5G8dQzcVRZNPsLsqBw/oGmQ==@vger.kernel.org X-Gm-Message-State: AFq9FYKcdSturVZMin4kgWSJqSkfgv6dPLBxGOmVptEX8rLUZokcgKPJ acJaIdhElMxBI5zhljEz1cRT68qk3IPf1LItN0UijR44z7D6dwt8IAJqqQGEeN2bmA0= X-Gm-Gg: AYBFou2wtiikDuZBRQsW/bnBRqbHC+P4MxB+4GX6msgVDBkkmeRwkd3yBaTtxu3sO7a UB8/LOr3yCXwIaTJKKgWO9Gs+f751Q+/VoReo6+4YRWdzjM2v5melclOgZN5KeRIIKSI8aTrGEz WhM42NhJQu8N6M96zaXyBis7JagtwfpFlH/T53duc7fYHnDna/SsFIze9TyVPb8M7Li/2aAUsvu Cdcg1/JK1DsMxeU4wdwEBd56zvaQPEritvXJrXoWE7ADO2Hc8/h8VvDzViAC9sYAmk0uWC95BSj lQrdYDplDH9fR0CtQaRZezTsxW8yhwjgNxshtAasibQ51zk/LJABe3VWY9iN1VQwkhMZdejT/ku QyoxpbrKIssmb5/iYFx6x5zS359gcSEmFzzu8ye0oaZ9TbMz8rvO+W2+w7rXIxF4/QIBfsq/YXV xjZ4KQRb1FFDXjjYkDgAES2RkxwNS/2YNV8KqjDcHNviKLGUfspmt6NzOtbb8uJKl0FCctqG3iu U1bKznv4941Q5lhkpxP2d1qOr2k1r/uIugsc4xrXn6kOkmWS2ujQUKcEA== X-Received: by 2002:a05:6820:162a:b0:6f7:75ab:f969 with SMTP id 006d021491bc7-6f775bb41f5mr1943854eaf.66.1791836471882; Mon, 12 Oct 2026 13:21:11 -0700 (PDT) Received: from [192.168.1.106] ([198.8.77.135]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-6ef02d91a5asm10237414eaf.14.2026.10.12.13.21.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Oct 2026 13:21:10 -0700 (PDT) Message-ID: <07d36bc7-637f-4554-9d6f-039e88852dc6@kernel.dk> Date: Mon, 12 Oct 2026 14:21:03 -0600 Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9 05/13] block: add dma-buf support for raw bdev To: Anuj Gupta/Anuj Gupta , Pavel Begunkov , linux-block@vger.kernel.org Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-nvme@lists.infradead.org, linux-fsdevel@vger.kernel.org, io-uring@vger.kernel.org, Christoph Hellwig , Sumit Semwal , =?UTF-8?Q?Christian_K=C3=B6nig?= , Keith Busch , Sagi Grimberg , Alexander Viro , Christian Brauner , Jan Kara , Andrew Morton , Nitesh Shetty , Kanchan Joshi , Mike Snitzer , Mikulas Patocka , Benjamin Marzinski , dm-devel@lists.linux.dev References: Content-Language: en-US From: Jens Axboe In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/8/26 6:27 AM, Anuj Gupta/Anuj Gupta wrote: > On 10/7/2026 7:12 AM, Pavel Begunkov wrote: >> +static int blkdev_init_dma_buf_io_ctx(struct file *file, >> + struct dma_buf_io_ctx *ctx) >> +{ >> + struct block_device *bdev = file_bdev(file); >> + struct gendisk *disk = bdev->bd_disk; >> + >> + if (!(file->f_flags & O_DIRECT)) >> + return -EINVAL; >> + if (!disk->fops->init_dma_buf_io_ctx) >> + return -EOPNOTSUPP; > > dma-buf doesn't work with PI: bi_dmabuf_map aliases bi_io_vec, and > blk_integrity_iterate() walks it as bvecs to generate/verify the > checksum. rw-dmabuf liburing test hangs on a PI enabled NVMe. Something > like below is needed: > > diff --git a/block/blk-mq.c b/block/blk-mq.c > index e929f94b25c7..1b7f8cbbda8b 100644 > --- a/block/blk-mq.c > +++ b/block/blk-mq.c > @@ -3150,6 +3150,12 @@ void blk_mq_submit_bio(struct bio *bio) > goto queue_exit; > } > > + if (unlikely(op_is_dmabuf(bio->bi_opf) && > + bdev_has_integrity_csum(bio->bi_bdev))) { > + bio_endio_status(bio, BLK_STS_NOTSUPP); > + goto queue_exit; > + } > + > if ((bio->bi_opf & REQ_POLLED) && !blk_mq_can_poll(q)) { > bio_endio_status(bio, BLK_STS_NOTSUPP); > goto queue_exit; > diff --git a/block/fops.c b/block/fops.c > index e9da48ab73be..6c6700df943c 100644 > --- a/block/fops.c > +++ b/block/fops.c > @@ -976,6 +976,8 @@ static int blkdev_init_dma_buf_io_ctx(struct file *file, > return -EINVAL; > if (!disk->fops->init_dma_buf_io_ctx) > return -EOPNOTSUPP; > + if (bdev_has_integrity_csum(bdev)) > + return -EOPNOTSUPP; > return disk->fops->init_dma_buf_io_ctx(bdev, ctx); > } Can you send a separate patch? I've queued this series up for some testing. -- Jens Axboe