From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@infradead.org>, Mike Snitzer <snitzer@redhat.com>
Cc: Matthew Wilcox <willy@infradead.org>,
dm-devel@redhat.com, linux-block@vger.kernel.org,
david@fromorbit.com
Subject: Re: bioset_exit poison from dm_destroy
Date: Wed, 1 Jun 2022 00:08:57 -0600 [thread overview]
Message-ID: <08625f5f-4781-52c5-46fc-d1250f70626c@kernel.dk> (raw)
In-Reply-To: <YpcBgY9MMgumEjTL@infradead.org>
On 6/1/22 12:04 AM, Christoph Hellwig wrote:
> On Tue, May 31, 2022 at 02:58:00PM -0400, Mike Snitzer wrote:
>> Yes, we need the above to fix the crash. Does it also make sense to
>> add this?
>
> Can we just stop treating bio_sets so sloppily and make the callers
> handle their lifetime properly? No one should have to use
> bioset_initialized (or double free bio_sets).
Yes, that was my point in the previous email - get rid of
bioset_initialized() and just fixup dm, which is the only user of it.
There really should be no need to have this kind of conditional checking
and initialization.
--
Jens Axboe
next prev parent reply other threads:[~2022-06-01 6:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-29 0:17 bioset_exit poison from dm_destroy Matthew Wilcox
2022-05-29 12:46 ` Jens Axboe
2022-05-31 18:58 ` Mike Snitzer
2022-05-31 19:00 ` Jens Axboe
2022-05-31 19:49 ` Mike Snitzer
2022-06-01 3:27 ` Jens Axboe
2022-06-01 6:04 ` Christoph Hellwig
2022-06-01 6:08 ` Jens Axboe [this message]
2022-06-01 6:18 ` Christoph Hellwig
2022-06-01 14:13 ` Mike Snitzer
2022-06-02 8:12 ` Christoph Hellwig
2022-06-02 8:18 ` Jens Axboe
2022-06-03 13:09 ` Mike Snitzer
2022-06-03 13:19 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08625f5f-4781-52c5-46fc-d1250f70626c@kernel.dk \
--to=axboe@kernel.dk \
--cc=david@fromorbit.com \
--cc=dm-devel@redhat.com \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=snitzer@redhat.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).