[PATCH 2/3] block: don't call freeze queue in elevator_switch() and elevator_disable()

Ming Lei
2025-04-02T04:39:50Z

Both elevator_switch() and elevator_disable() are called from sysfs
store and updating nr_hw_queue code paths only.

And in the two code paths, queue has been frozen already, so don't call
freeze queue in the two functions.

Signed-off-by: Ming Lei <ming.lei@redhat.com>
---
block/elevator.c | 7 -------
1 file changed, 7 deletions(-)

diff --git a/block/elevator.c b/block/elevator.c
index b4d08026b02c..4d3a8f996c91 100644
--- a/block/elevator.c
+++ b/block/elevator.c
@@ -615,12 +615,10 @@ void elevator_init_mq(struct request_queue *q)
*/
int elevator_switch(struct request_queue *q, struct elevator_type *new_e)
{
- unsigned int memflags;
int ret;

lockdep_assert_held(&q->elevator_lock);

- memflags = blk_mq_freeze_queue(q);
blk_mq_quiesce_queue(q);

if (q->elevator) {
@@ -641,7 +639,6 @@ int elevator_switch(struct request_queue *q, struct elevator_type *new_e)

out_unfreeze:
blk_mq_unquiesce_queue(q);
- blk_mq_unfreeze_queue(q, memflags);

if (ret) {
pr_warn("elv: switch to \"%s\" failed, falling back to \"none\"\n",
@@ -653,11 +650,8 @@ int elevator_switch(struct request_queue *q, struct elevator_type *new_e)

void elevator_disable(struct request_queue *q)
{
- unsigned int memflags;
-
lockdep_assert_held(&q->elevator_lock);

- memflags = blk_mq_freeze_queue(q);
blk_mq_quiesce_queue(q);

elv_unregister_queue(q);
@@ -668,7 +662,6 @@ void elevator_disable(struct request_queue *q)
blk_add_trace_msg(q, "elv switch: none");

blk_mq_unquiesce_queue(q);
- blk_mq_unfreeze_queue(q, memflags);
}

/*
--
2.47.0