Re: [PATCH 1/3] block: add blk_mq_enter_no_io() and blk_mq_exit_no_io()

Nilay Shroff
2025-04-02T13:50:37Z

On 4/2/25 10:08 AM, Ming Lei wrote:
> Add blk_mq_enter_no_io() and blk_mq_exit_no_io() for preventing queue
> from handling any FS or passthrough IO, meantime the queue is kept in
> non-freeze state.
>
> The added two APIs are for avoiding many potential lock risk related
> with freeze lock.
>
> Also add two variants of memsave version.
>
> Signed-off-by: Ming Lei <ming.lei@redhat.com>

I hope you will spin another patch replacing '||' with '&&' in
blk_queue_enter and __bio_queue_enter as you mentioned in another
mail. With that change, this looks good to me:

Reviewed-by: Nilay Shroff <nilay@linux.ibm.com>