Re: [PATCH v5 02/12] blk-mq: fix direct issue

Bart Van Assche
2017-06-06T16:16:23Z

On Tue, 2017-06-06 at 23:22 +0800, Ming Lei wrote:
> If queue is stopped, we shouldn't dispatch request into driver and
> hardware, unfortunately the check is removed in bd166ef183c2(blk-mq-sched=
:
> add framework for MQ capable IO schedulers).
>=20
> This patch fixes the issue by moving the check back into
> __blk_mq_try_issue_directly().
>=20
> This patch fixes request use-after-free[1][2] during canceling requets
> of NVMe in nvme_dev_disable(), which can be triggered easily during
> NVMe reset & remove test.

Although I'm not convinced that this patch fixes [2], the patch itself look=
s
fine to me. Hence:

Reviewed-by: Bart Van Assche <Bart.VanAssche@sandisk.com>=