Re: [PATCH 0/2] block, nvme: minor fixes to dma-buf support

[Pavel Begunkov <asml.silence@gmail.com>]

On 10/21/26 19:46, Keith Busch wrote:
> From: Keith Busch <kbusch@kernel.org>
> 
> Just a couple minor fixes. I wish I could say I caught the first one
> myself, but no, I prompted an LLM to look at it.
> 
> I am assuming changing the bi_offset type to accomodate large offsets
> isn't acceptable as the bvec_iter's size appears to be packed to be
> small. I think there's a path to accepting larger offsets through
> bi_idx, but the patch proposed here is a safer quick fix.

It'd be curious to hear how you want to pack it. On the same note,
we'll eventually also need support vectored readv/writev and very
likely have the same problem. E.g. we'd either need to keep map in
another field (perhaps in bio only), or demormalising data and
keeping an array of {map,off,len}.


> Keith Busch (2):
>    block: reject dma-bufs larger than 4GiB
>    nvme-pci: detach dma-bufs only on removal
> 
>   block/fops.c            | 4 ++++
>   drivers/nvme/host/pci.c | 4 +---
>   2 files changed, 5 insertions(+), 3 deletions(-)
> 

-- 
Pavel Begunkov