[PATCH 1/1] null_blk: Fix the problem "mutex_destroy missing"

[PATCH 1/1] null_blk: Fix the problem "mutex_destroy missing"

[Zhu Yanjun]

When a mutex lock is not used any more, the function mutex_destroy
should be called to mark the mutex lock uninitialized.

Signed-off-by: Zhu Yanjun <yanjun.zhu@linux.dev>
---
 drivers/block/null_blk/main.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/block/null_blk/main.c b/drivers/block/null_blk/main.c
index ed33cf7192d2..eed63f95e89d 100644
--- a/drivers/block/null_blk/main.c
+++ b/drivers/block/null_blk/main.c
@@ -2113,6 +2113,8 @@ static void __exit null_exit(void)
 
 	if (tag_set.ops)
 		blk_mq_free_tag_set(&tag_set);
+
+	mutex_destroy(&lock);
 }
 
 module_init(null_init);
-- 
2.20.1

Re: [PATCH 1/1] null_blk: Fix the problem "mutex_destroy missing"

[Zhu Yanjun]

在 2024/4/25 17:38, Zhu Yanjun 写道:
> When a mutex lock is not used any more, the function mutex_destroy
> should be called to mark the mutex lock uninitialized.
> 

Sorry. Fixes tag is missing.
I will send out the V2 with this Fixes tag.

Zhu Yanjun

> Signed-off-by: Zhu Yanjun <yanjun.zhu@linux.dev>
> ---
>   drivers/block/null_blk/main.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/block/null_blk/main.c b/drivers/block/null_blk/main.c
> index ed33cf7192d2..eed63f95e89d 100644
> --- a/drivers/block/null_blk/main.c
> +++ b/drivers/block/null_blk/main.c
> @@ -2113,6 +2113,8 @@ static void __exit null_exit(void)
>   
>   	if (tag_set.ops)
>   		blk_mq_free_tag_set(&tag_set);
> +
> +	mutex_destroy(&lock);
>   }
>   
>   module_init(null_init);

Re: [PATCH 1/1] null_blk: Fix the problem "mutex_destroy missing"

[Jens Axboe]

On 4/25/24 10:16 AM, Zhu Yanjun wrote:
> ? 2024/4/25 17:38, Zhu Yanjun ??:
>> When a mutex lock is not used any more, the function mutex_destroy
>> should be called to mark the mutex lock uninitialized.
>>
> 
> Sorry. Fixes tag is missing.
> I will send out the V2 with this Fixes tag.

Then please also fix the commit title, it's pretty bad. Make it
something ala:

null_blk: fix missing mutex_destroy() at module removal

-- 
Jens Axboe

Re: [PATCH 1/1] null_blk: Fix the problem "mutex_destroy missing"

[Zhu Yanjun]

在 2024/4/25 18:22, Jens Axboe 写道:
> On 4/25/24 10:16 AM, Zhu Yanjun wrote:
>> ? 2024/4/25 17:38, Zhu Yanjun ??:
>>> When a mutex lock is not used any more, the function mutex_destroy
>>> should be called to mark the mutex lock uninitialized.
>>>
>> Sorry. Fixes tag is missing.
>> I will send out the V2 with this Fixes tag.
> Then please also fix the commit title, it's pretty bad. Make it
> something ala:

Got it.

Zhu Yanjun

> null_blk: fix missing mutex_destroy() at module removal
>
-- 
I only represent myself.