From: Jens Axboe <axboe@kernel.dk>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-block@vger.kernel.org
Subject: Re: [PATCH] blk-mq: no need to check return value of debugfs_create functions
Date: Thu, 13 Jun 2019 02:54:50 -0600 [thread overview]
Message-ID: <0974f13e-37cf-6706-e1ae-7facf61c0215@kernel.dk> (raw)
In-Reply-To: <20190612123019.25112-1-gregkh@linuxfoundation.org>
On 6/12/19 6:30 AM, Greg Kroah-Hartman wrote:
> When calling debugfs functions, there is no need to ever check the
> return value. The function can work or not, but the code logic should
> never do something different based on this.
>
> When all of these checks are cleaned up, lots of the functions used in
> the blk-mq-debugfs code can now return void, as no need to check the
> return value of them either.
>
> Overall, this ends up cleaning up the code and making it smaller, always
> a nice win.
Applied, thanks Greg.
--
Jens Axboe
prev parent reply other threads:[~2019-06-13 15:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-12 12:30 [PATCH] blk-mq: no need to check return value of debugfs_create functions Greg Kroah-Hartman
2019-06-13 8:54 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0974f13e-37cf-6706-e1ae-7facf61c0215@kernel.dk \
--to=axboe@kernel.dk \
--cc=gregkh@linuxfoundation.org \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).